-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable non-existent zoom levels with tile overscaling #156
Comments
This works in native Leaflet layers: Leaflet/Leaflet#1798 and Leaflet/Leaflet#1802 However, it doesn't in the Google map tile plugin. It seems that we should be able to get L.Google to inherit from L.TileLayer (as in this abandoned pull request) to allow it to inherit this ability, but that doesn't seem to be working in my tests. I think L.Google overrides some other L.TileLayer methods, which we have to port back in; key sections here: Leaflet/Leaflet@b03f322#diff-41e07cc2f66148151bde6b9e17c7f183R461 |
How urgent is this? Should I work on #153 instead? |
… it doesnt yet work w/ L.Google as per #156
It looks like the Google tile plugin was refactored for v1.0 of Leaflet: shramov/leaflet-plugins#112 That means this may be easier to implement now, as the above error may not break it. We'd need to update the dependency in bower.json (https://github.com/publiclab/mapknitter/blob/master/bower.json#L17) to:
and run I think we may need to change line 13 of this file, but it's already set to 24, which I believe is high enough, so it might be a simple upgrade and it'll start working. https://github.com/publiclab/mapknitter/tree/master/app/assets/javascripts/mapknitter/Map.js#L13 |
This is great news as it would make MapKnitter much more useful for high-resolution low-altitude maps. On the off chance that it was already working, I had a look at some previous maps I made. Zooming is limited to 30 m (based on the scale on the bottom-left). Unfortunately, MapKnitter gets stuck at that zoom level and doesn't allow panning after zooming in (or out). After looking at this again, it looks like new maps work fine. |
This was solved with our upgrade to Leaflet 1.x! |
I'm trying to work with pole photos and they are about 1cm square on my screen at the lowest zoom level possible. Is there any way to work smaller? I don't need better resolution. my experience is suggesting that auto-placement will make pole mapping easier but I can't prove it because of #153
The text was updated successfully, but these errors were encountered: