Skip to content

Commit

Permalink
Using strong params in requests
Browse files Browse the repository at this point in the history
  • Loading branch information
alaxalves committed Aug 6, 2019
1 parent 74b75ca commit 9191cf6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions app/controllers/images_controller.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
require 'open-uri'
class ImagesController < ApplicationController
rescue_from Errno::ENOENT, Errno::ETIMEDOUT,
OpenURI::HTTPError, Timeout::Error,
with: :url_upload_not_found
OpenURI::HTTPError, Timeout::Error,
with: :url_upload_not_found
protect_from_forgery except: %i(update delete)
# Convert model to json without including root name. Eg. 'warpable'
ActiveRecord::Base.include_root_in_json = false
Expand Down
10 changes: 5 additions & 5 deletions test/controllers/images_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def fetch_in_production
test 'creates version after image creation' do
session[:user_id] = 1
assert_difference 'PaperTrail::Version.count', 1 do
post :create, map_id: @map.slug, uploaded_data: @uploaded_data
post :create, params: { map_id: @map.slug, uploaded_data: @uploaded_data }
end
warp = Warpable.last
assert warp.versions.present?
Expand All @@ -94,7 +94,7 @@ def fetch_in_production
session[:user_id] = 1

assert_difference 'PaperTrail::Version.count', 1 do
patch :update, id: @map.id, warpable_id: @warp.id, locked: false, points: points
patch :update, params: { id: @map.id, warpable_id: @warp.id, locked: false, points: points }
end
assert_response :success
assert @warp.versions.present?
Expand All @@ -106,12 +106,12 @@ def fetch_in_production
points1 = "-72.39,41.83:-72.39,41.83:-72.39,41.83:-72.39,41.84"
points2 = "-72.39,40.83:-72.39,41.83:-72.39,41.83:-71.39,45.84"

patch :update, id: @map.id, warpable_id: @warp.id, locked: false, points: points1
patch :update, params: { id: @map.id, warpable_id: @warp.id, locked: false, points: points1 }
@warp.reload
nodes_latest = @warp.nodes
patch :update, id: @map.id, warpable_id: @warp.id, locked: false, points: points2
patch :update, params: { id: @map.id, warpable_id: @warp.id, locked: false, points: points2 }
assert_difference 'PaperTrail::Version.count', 1 do
get :revert, id: @warp.id, version: @warp.versions.last
get :revert, params: { id: @warp.id, version: @warp.versions.last }
end
@warp.reload
assert_equal(nodes_latest, @warp.nodes)
Expand Down

0 comments on commit 9191cf6

Please sign in to comment.