Fixing prod host for travis, private class usage and rubocop offenses

.travis.yml

@@ -19,8 +19,10 @@ install:
   - ./lib/exporter-deps.sh > /dev/null 2>&1
   - bundle check --path vendor/.bundle/ || bundle install --path vendor/.bundle/
   - yarn check || yarn install
-  - mysql -e "CREATE DATABASE mapknitter_test; CREATE DATABASE mapknitter;"
   - if [ $RAILS_ENV == 'production' ]; then
+      mysql -e "CREATE DATABASE mapknitter;";
+      mysql -e "CREATE USER 'mapknitter'@'%' IDENTIFIED BY 'mapknitter';";
+      mysql -e "GRANT ALL PRIVILEGES ON *.* TO 'mapknitter'@'%';";
       bundle exec rails db:schema:load;
     else
       bundle exec rails db:setup || bundle exec rails db:migrate;

app/controllers/front_ui_controller.rb

@@ -8,9 +8,11 @@ def index
     @maps = Map.new_maps.first(4)
     @unpaginated = true
     # TODO: these could use optimization but are better than prev:
-    tag = Tag.where(name: 'featured').first # note that this is not a join table but the .maps method still works
-    @mappers = User.where(login: tag.maps.collect(&:author)) if tag
-    @mappers ||= []
+    @mappers = if Tag.where(name: 'featured').first
+                 User.where(login: tag.maps.collect(&:author))
+               else
+                 []
+               end
   end
 
   def all_maps

app/helpers/front_ui_helper.rb

@@ -1,7 +1,6 @@
 module FrontUiHelper
   def profile_image(author)
-    img = author&.warpables&.last&.image&.url
-    img ||= "/images/yarn.png"
+    author&.warpables&.last&.image&.url || "/images/yarn.png"
   end
 
   def anonymous(maps)

config/database.yml.example

@@ -14,7 +14,7 @@ production:
   adapter: mysql2
   encoding: utf8
   pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %>
-  host: db
+  host: <%= ENV.fetch("MYSQL_HOST") { '127.0.0.1' } %>
   username: mapknitter
   password: mapknitter
   database: mapknitter

mapknitter.env

@@ -2,4 +2,5 @@ MYSQL_DATABASE=mapknitter
 MYSQL_USER=mapknitter
 MYSQL_PASSWORD=mapknitter
 MYSQL_RANDOM_ROOT_PASSWORD=true
+MYSQL_HOST=db
 RAILS_ENV=production

test/unit/user_test.rb

@@ -43,7 +43,12 @@ class UserTest < ActiveSupport::TestCase
     user = users(:quentin)
     map_images = user.maps.map(&:warpables)
 
-    assert_equal Warpable::ActiveRecord_Associations_CollectionProxy, user.warpables.class
+    map_images.flatten.each do |image|
+      user.warpables.each do |warpable|
+        assert_equal image.class, warpable.class
+      end
+    end
+
     assert_equal map_images.flatten, user.warpables
   end