Setup GitHub Actions

[aliciapaz]

Migrating to Travis for CI

• Exporter Tests
• Rubocop
• Docker Build

[gitpod-io]

[jywarren]

@icarito will this trigger a rebuild? Maybe we should do on a day we're online?

Looks awesome @aliciapaz!!!

[jywarren]

Oh odd, looks like an error but it didn't return it!

examples, 0 failures

/home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/lib/export.rb:74:in `save': undefined method `files' for nil:NilClass (NoMethodError)
	from /home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/vendor/bundle/ruby/2.4.0/gems/mapknitter-exporter-1.0.9/lib/mapknitterExporter.rb:329:in `run_export'

[jywarren]

Does it need the ruby files class included? Or something?

[icarito]

Indeed the trigger is set for `main` branch. We could change it to `stable` branch to keep in line with other repositories. -- Sebastian Silva El sáb, 25 sept 2021 a las 8:23, Jeffrey Warren ***@***.***>) escribió:

…

@icarito <https://github.com/icarito> will this trigger a rebuild? Maybe we should do on a day we're online? Looks awesome @aliciapaz <https://github.com/aliciapaz>!!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQYS343UYPSCTGJFLTRBDUDXEOBANCNFSM5EOQ6QTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[aliciapaz]

Thank you both!

Indeed the trigger is set for main branch. We could change it to stable branch to keep in line with other repositories.

@icarito Where is this change to be done?

[icarito]

We're using the Google Cloud Build service to monitor the repo and trigger builds. This is something that needs to be configured at the Google Cloud Console by a privileged user (I could do it, just need confirmation). Thanks for working on this! -- Sebastian Silva El sáb, 25 sept 2021 a las 8:51, Alicia Paz ***@***.***>) escribió:

…

Thank you both! Indeed the trigger is set for main branch. We could change it to stable branch to keep in line with other repositories. @icarito <https://github.com/icarito>! Where is this change to be done? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQYS3T5JDMYXV347GVP43UDXHXXANCNFSM5EOQ6QTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[aliciapaz]

Oh odd, looks like an error but it didn't return it!

examples, 0 failures

/home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/lib/export.rb:74:in `save': undefined method `files' for nil:NilClass (NoMethodError)
	from /home/runner/work/mapknitter-exporter-sinatra/mapknitter-exporter-sinatra/vendor/bundle/ruby/2.4.0/gems/mapknitter-exporter-1.0.9/lib/mapknitterExporter.rb:329:in `run_export'

Does it need the ruby files class included? Or something?

I think not...it looks more like something is nil in a moment when it shouldn't. I noticed when debugging that the @directory variable is nil after is created inside the initialize method of Export.rb (line 36), and it is as well when the export.save call is made.

[jywarren]

I think not...it looks more like something is nil in a moment when it shouldn't. I noticed when debugging that the @directory variable is nil after is created inside the initialize method of Export.rb (line 36), and it is as well when the export.save call is made.

Ah ok, does this need some further debugging then? Was this error happening same way in Travis?

@icarito i think once @aliciapaz confirms this is good to go, we can just merge it and manually monitor and test an export, just to be sure. I guess someday we should make it republish /only/ if we bump the version or something, or switch it to stable, but it's really not that important, this service is basically completely stable.

[icarito]

Agreed. 👍 -- Sebastian Silva El mar, 28 sept 2021 a las 9:35, Jeffrey Warren ***@***.***>) escribió:

…

I think not...it looks more like something is nil in a moment when it shouldn't. I noticed when debugging that the @Directory variable is nil after is created inside the initialize method of Export.rb (line 36), and it is as well when the export.save call is made. Ah ok, does this need some further debugging then? Was this error happening same way in Travis? @icarito <https://github.com/icarito> i think once @aliciapaz <https://github.com/aliciapaz> confirms this is good to go, we can just merge it and manually monitor and test an export, just to be sure. I guess someday we should make it republish /only/ if we bump the version or something, or switch it to stable, but it's really not that important, this service is basically completely stable. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQYSZ6Y5EWF5SBK577VP3UEHHBHANCNFSM5EOQ6QTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[aliciapaz]

Yes, this is a Travis run from about a year ago:
https://app.travis-ci.com/github/publiclab/mapknitter-exporter-sinatra/jobs/423729539

So yes, we're good to go 👍🏽
Thanks!!

[jywarren]

OK Great - i'll open an issue for this just to track but it seems harmless with @aliciapaz's confirmation - here's the old Travis log that's exactly the same; the tests pass even though it shows this error, and the error does not disrupt the actual export:

undefined method `files' for nil:NilClass (NoMethodError)
	from /home/travis/build/publiclab/mapknitter-exporter-sinatra/vendor/.bundle/ruby/2.4.0/gems/mapknitter-exporter-1.0.9/lib/mapknitterExporter.rb:329:in `run_export'
	from /home/travis/build/publiclab/mapknitter-exporter-sinatra/app/controllers/export_controller.rb:73:in `block in run_export'
	from /home/travis/build/publiclab/mapknitter-exporter-sinatra/app/controllers/export_controller.rb:71:in `fork'
	from /home/travis/build/publiclab/mapknitter-exporter-sinatra/app/controllers/export_controller.rb:71:in `run_export'
	from /home/travis/build/publiclab/mapknitter-exporter-sinatra/app/controllers/export_controller.rb:35:in `block in <top (required)>'