Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to github actions from travis #492

Closed
wants to merge 19 commits into from
Closed

moving to github actions from travis #492

wants to merge 19 commits into from

Conversation

jywarren
Copy link
Member

moving to github actions! Also note Cypress setup here: #402

@jywarren
Copy link
Member Author

@jywarren
Copy link
Member Author

Hmm. this grunt location issue is causing trouble...


  npm run start:ci
  shell: /bin/bash -e {0}
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN saveError ENOENT: no such file or directory, open '/home/runner/work/leaflet-environmental-layers/leaflet-environmental-layers/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/home/runner/work/leaflet-environmental-layers/leaflet-environmental-layers/package.json'
npm WARN leaflet-environmental-layers No description
npm WARN leaflet-environmental-layers No repository field.
npm WARN leaflet-environmental-layers No README data
npm WARN leaflet-environmental-layers No license field.

+ grunt-cli@1.3.2
+ grunt@1.3.0
added 196 packages from 160 contributors and audited 196 packages in 7.337s

6 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

A valid Gruntfile could not be found. Please see the getting started guide for
more information on how to configure grunt: http://gruntjs.com/getting-started
Fatal error: Unable to find Gruntfile.�

@jywarren
Copy link
Member Author

Hmm. Just noting that this all runs fine in GitPod:

          npm install grunt grunt-cli
          node_modules/grunt-cli/bin/grunt build
          node_modules/grunt-cli/bin/grunt transpile
          node_modules/grunt-cli/bin/grunt jasmine
          npm run start:ci

@jywarren
Copy link
Member Author

I believe this is working now, but tests are failing!

@jywarren
Copy link
Member Author

for example getting a lot of

  6) Fractracker layer removes markers from the map and the layer name from the hash when clicked again:
     TypeError: Cannot read property 'documentElement' of undefined

@jywarren
Copy link
Member Author

I removed redundant extra cypress run but still look at this from before I did: https://github.com/publiclab/leaflet-environmental-layers/runs/1624024928?check_suite_focus=true

@jywarren
Copy link
Member Author

Also... # use the new "ci" command for fastest installs on CI

  • npm ci

@jywarren
Copy link
Member Author

# just for full picture after installing Cypress
# print information about detected browsers, etc
# see https://on.cypress.io/command-line#cypress-info
build: npx cypress info
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work... I think we need to better configure cypress to get past the undefined takeScreenshot error from the previous commit...

@jywarren
Copy link
Member Author

jywarren commented Jan 28, 2021

Seeing this now:

> phantomjs-prebuilt@2.1.16 install /home/runner/work/leaflet-environmental-layers/leaflet-environmental-layers/node_modules/phantomjs-prebuilt
> node install.js

Considering PhantomJS found at /usr/local/bin/phantomjs
Found PhantomJS at /usr/local/bin/phantomjs ...verifying
Writing location.js file
PhantomJS is already installed on PATH at /usr/local/bin/phantomjs

we should try switching Cypress to Headless Chrome instead. The errors are all like this now;


     TypeError: Cannot read property 'documentElement' of undefined
      at takeScreenshot (http://localhost:8080/__cypress/runner/cypress_runner.js:88702:72)
      at $Cypress.<anonymous> (http://localhost:8080/__cypress/runner/cypress_runner.js:88734:12)
      at listener (http://localhost:8080/__cypress/runner/cypress_runner.js:98444:19)
      at tryCatcher (http://localhost:8080/__cypress/runner/cypress_runner.js:136088:23)
      at MappingPromiseArray._promiseFulfilled (http://localhost:8080/__cypress/runner/cypress_runner.js:133209:38)
      at MappingPromiseArray.PromiseArray._iterate (http://localhost:8080/__cypress/runner/cypress_runner.js:134410:31)
      at MappingPromiseArray.init (http://localhost:8080/__cypress/runner/cypress_runner.js:134374:10)
      at MappingPromiseArray._asyncInit (http://localhost:8080/__cypress/runner/cypress_runner.js:133178:10)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://localhost:8080/__cypress/runner/cypress_runner.js:130818:12)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130823:10)
      at Async.drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130697:14)

@jywarren
Copy link
Member Author

Solved in #503

@jywarren jywarren closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant