add owmloading.gif file

[Tlazypanda]

Fixes publiclab/plots2#5095

Added owmloading gif file and changed the path of referencing the file.

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[Tlazypanda]

@jywarren can you kindly review? Thanks ✌️

[jywarren]

Trying to retrigger tests here! If they fail again, would you mind quoting out the error into the comments and we can troubleshoot? Thank you!!!!

[Tlazypanda]

Hey @jywarren here are the failed results -
CypressError: Timed out retrying: Expected to find element: '', but never found it. Queried from element: <div.leaflet-pane.leaflet-marker-pane>
CypressError: Timed out retrying: Expected to find element: '.leaflet-marker-pane img', but never found it.

I don't think they are related to this but I am not sure 😅 some of the failed tests here are also failing in this dependabot pr #474 https://travis-ci.org/github/publiclab/leaflet-environmental-layers/builds/703823456 so I am not sure

[jywarren]

I think you're correct. Note it seems related to Skytruth:

  2 failing
  1) Skytruth layer adds markers on click:

Can you check the blame on the skytruth test itself? Maybe it's relying on the wrong or out of date SkyTruth API? #336 #384 also show some skytruth-related view changes, maybe we broke something back then?

Thank you @Tlazypanda ! Great investigating!!!

[jywarren]

https://github.com/buche/leaflet-openweathermap/blob/master/example/leaflet/owmloading.gif

[jywarren]

These errors were due to Skytruth, and since we're still on Skytruth's orig and old API i think we may need to turn off the tests for that until we can update it to v2 API -- will try to find a reference:

  2 failing
  1) Skytruth layer adds markers on click:
     CypressError: Timed out retrying: Expected to find element: '', but never found it. Queried from element: <div.leaflet-pane.leaflet-marker-pane>
      at Object.cypressErr (http://localhost:8080/__cypress/runner/cypress_runner.js:102176:11)
      at Object.throwErr (http://localhost:8080/__cypress/runner/cypress_runner.js:102128:18)
      at Object.throwErrByPath (http://localhost:8080/__cypress/runner/cypress_runner.js:102163:17)
      at retry (http://localhost:8080/__cypress/runner/cypress_runner.js:92756:16)
      at onFailFn (http://localhost:8080/__cypress/runner/cypress_runner.js:80982:16)
      at tryCatcher (http://localhost:8080/__cypress/runner/cypress_runner.js:136088:23)
      at Promise._settlePromiseFromHandler (http://localhost:8080/__cypress/runner/cypress_runner.js:134024:31)
      at Promise._settlePromise (http://localhost:8080/__cypress/runner/cypress_runner.js:134081:18)
      at Promise._settlePromise0 (http://localhost:8080/__cypress/runner/cypress_runner.js:134126:10)
      at Promise._settlePromises (http://localhost:8080/__cypress/runner/cypress_runner.js:134201:18)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://localhost:8080/__cypress/runner/cypress_runner.js:130813:16)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130823:10)
      at Async.drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130697:14)
  2) Skytruth layer has default markers in default mode:
     CypressError: Timed out retrying: Expected to find element: '.leaflet-marker-pane img', but never found it.
      at Object.cypressErr (http://localhost:8080/__cypress/runner/cypress_runner.js:102176:11)
      at Object.throwErr (http://localhost:8080/__cypress/runner/cypress_runner.js:102128:18)
      at Object.throwErrByPath (http://localhost:8080/__cypress/runner/cypress_runner.js:102163:17)
      at retry (http://localhost:8080/__cypress/runner/cypress_runner.js:92756:16)
      at onFailFn (http://localhost:8080/__cypress/runner/cypress_runner.js:80982:16)
      at tryCatcher (http://localhost:8080/__cypress/runner/cypress_runner.js:136088:23)
      at Promise._settlePromiseFromHandler (http://localhost:8080/__cypress/runner/cypress_runner.js:134024:31)
      at Promise._settlePromise (http://localhost:8080/__cypress/runner/cypress_runner.js:134081:18)
      at Promise._settlePromise0 (http://localhost:8080/__cypress/runner/cypress_runner.js:134126:10)
      at Promise._settlePromises (http://localhost:8080/__cypress/runner/cypress_runner.js:134201:18)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueue (http://localhost:8080/__cypress/runner/cypress_runner.js:130813:16)
      at Async../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130823:10)
      at Async.drainQueues (http://localhost:8080/__cypress/runner/cypress_runner.js:130697:14)

[jywarren]

Link to Skytruth API issue: #118

[jywarren]

But these are timeout errors so maybe we can just... lengthen timeout?

[jywarren]

Let's see how this does after #503

[jywarren]

Yes, https://alerts1.skytruth.org/json?n=100&l=29.103173641957888,-90.26628971099854,29.4625145059195,-88.44942569732667 hits a HTTPS cert error and probably errors. http://alerts1.skytruth.org/json?n=100&l=29.103173641957888,-90.26628971099854,29.4625145059195,-88.44942569732667 works but...

[jywarren]

Last one, @RuthNjeri and then we can modify your PR!

[jywarren]

Nice! Merging!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.