-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static html table menu #193
Static html table menu #193
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Oooooohhhhh! @ananyaarun @sagarpreet-chadha @stefannibrasil this is pretty awesome, just static HTML to build on top of -- what do you think? |
that looks awesome! |
@rarrunategu1 this is great !! |
Thank you. Today I'll be putting the finishing touches on it. I planned on it yesterday but I wasn't feeling well. If you have any suggestions, please feel free to share them. :) |
…on having icon toggle based on if the group layer is open or not. Will correct checkbox functionalities with id changes shortly
@rarrunategu1 is there anything I can contribute to or help with this PR ? |
…nd toggles icon when clicked on
@jywarren @sagarpreet-chadha @stefannibrasil @ananyaarun I've added the collapsible rows and basically just have a template ready to push. Please take a look at it and let me know if there's anything I may have missed that you feel should be included. |
Thanks! Ananya, can you give it a try? If this looks good we can merge and
address any other issues in a follow-up PR!
…On Tue, Jun 4, 2019, 12:12 PM rarrunategu1 ***@***.***> wrote:
@jywarren <https://github.com/jywarren> @sagarpreet-chadha
<https://github.com/sagarpreet-chadha> @stefannibrasil
<https://github.com/stefannibrasil> @ananyaarun
<https://github.com/ananyaarun> I've added the collapsible rows and
basically just have a template ready to push. Please take a look at it and
let me know if there's anything I may have missed that you feel should be
included.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193?email_source=notifications&email_token=AAAF6J2YTLHTLMLJZTOSGJ3PY2H6PA5CNFSM4HQWUJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5CSNY#issuecomment-498739511>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J5CV2WQPUPWQ6B6I2TPY2H6PANCNFSM4HQWUJ4A>
.
|
I love this 😍 ! @rarrunategu1 ...can we use hosted URL of the image in the code instead of adding the image in the library ? You can remove the image from this PR . Some follow up issues we can discuss :
Thank you ! |
Ok! Want to offer an approving review and we can go ahead and merge it
then? Thanks!!!
…On Thu, Jun 6, 2019, 4:51 AM Ananya Arun ***@***.***> wrote:
I tried this out locally. It looks great!!!
Here is a working gif
[image: static]
<https://user-images.githubusercontent.com/32260628/59030407-8af3c880-887e-11e9-8aad-e9c7012ea793.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193?email_source=notifications&email_token=AAAF6J5CETNOTZWEPTSDPCDPZD2YXA5CNFSM4HQWUJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCTCIY#issuecomment-499462435>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZFVIN6OFZMNX53SEDPZD2YXANCNFSM4HQWUJ4A>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to merge once the image is removed from templates and replaced with the hosted URL instead as @sagarpreet-chadha suggested.
Thanks !!
Hello @sagarpreet-chadha, above you suggested that we use hosted URL of the image in the code instead of adding the image in the library ? Then I see an approving review. I'm still trying to understand what all of this means. Were the changes made or should I remove the image at the top to be able to merge this? |
Hey! |
… a sensor to match the format of the others
I've made the changes @sagarpreet-chadha. I appreciate everyone's feedback. It's now ready to merge @jywarren :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome !!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Awesome work, folks!
…On Tue, Jun 11, 2019 at 1:22 PM welcome[bot] ***@***.***> wrote:
Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to
https://publiclab.github.io/leaflet-environmental-layers/example/ in the
next few days.
Do join our weekly check-in to share your this week goal and the awesome
work you did 😃. Please find the link *pinned in the issue section* 📝
Now that you've completed this, you can help someone else take their first
step!
Reach out to someone else working on theirs on Public Lab's code welcome
page <https://code.publiclab.org#r=all>. Thanks!
*Help others take their first step*
Now that you've merged your first pull request, you're the perfect person
to help someone else out with this challenging first step. 🙌
https://code.publiclab.org <https://code.publiclab.org#r=all>
Try looking at this list of `first-timers-only` issues, and see if someone
else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help
someone get unstuck, or help lead them to some documentation that'd help.
Reach out and be encouraging and friendly! 😄 🎉
Read about how to help support another newcomer here
<publiclab/plots2#3458>, or find other ways to
offer mutual support here
<https://github.com/publiclab/plots2/labels/support>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193?email_source=notifications&email_token=AAAF6J4NEUMATBHGHC34B3LPZ7NLTA5CNFSM4HQWUJ4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXN4HVY#issuecomment-500941783>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J2PGDFUPVABNJ2C57DPZ7NLTANCNFSM4HQWUJ4A>
.
|
Fixes #192 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewers
for help, in a comment belowStill a working progress. I have a few more things to add so it's not quite ready for review but I'm open to any suggestions based on what may be needed. I do have a png file that is not being used but that's because I couldn't find the original for better quality. I may delete it later.