Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static html table menu #193

Merged

Conversation

rarrunategu1
Copy link
Contributor

@rarrunategu1 rarrunategu1 commented May 29, 2019

Fixes #192 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Still a working progress. I have a few more things to add so it's not quite ready for review but I'm open to any suggestions based on what may be needed. I do have a png file that is not being used but that's because I couldn't find the original for better quality. I may delete it later.

image

@welcome
Copy link

welcome bot commented May 29, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@jywarren
Copy link
Member

Oooooohhhhh! @ananyaarun @sagarpreet-chadha @stefannibrasil this is pretty awesome, just static HTML to build on top of -- what do you think?

@stefannibrasil
Copy link

that looks awesome!
We can potentially use it on the new front-page, it would fit really well 💅

@ananyaarun
Copy link
Member

@rarrunategu1 this is great !!

@rarrunategu1
Copy link
Contributor Author

Thank you. Today I'll be putting the finishing touches on it. I planned on it yesterday but I wasn't feeling well. If you have any suggestions, please feel free to share them. :)

…on having icon toggle based on if the group layer is open or not. Will correct checkbox functionalities with id changes shortly
@ananyaarun
Copy link
Member

ananyaarun commented Jun 4, 2019

@rarrunategu1 is there anything I can contribute to or help with this PR ?
Do let me know :)

@rarrunategu1
Copy link
Contributor Author

@jywarren @sagarpreet-chadha @stefannibrasil @ananyaarun I've added the collapsible rows and basically just have a template ready to push. Please take a look at it and let me know if there's anything I may have missed that you feel should be included.

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

@sagarpreet-chadha
Copy link
Collaborator

I love this 😍 !

@rarrunategu1 ...can we use hosted URL of the image in the code instead of adding the image in the library ? You can remove the image from this PR .

Some follow up issues we can discuss :

  • Clicking Add a Report button should open a modal which has all the fields that the POST request of the API wants . (Will be different for different API's) .

  • Google maps also has a similar feature to add report --- we can use UI similar to that (especially in mobile view) .

  • Writing AJAX call to POST report as a common function which can be used for all API's .
    One function where we pass different parameters including the URL of API , and it sends POST request to that API .

  • Integrating to projects --- mapknitter and plots2 :)

Thank you !

@ananyaarun
Copy link
Member

I tried this out locally. It looks great!!!
Here is a working gif
static

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge once the image is removed from templates and replaced with the hosted URL instead as @sagarpreet-chadha suggested.
Thanks !!

@rarrunategu1
Copy link
Contributor Author

Hello @sagarpreet-chadha, above you suggested that we use hosted URL of the image in the code instead of adding the image in the library ? Then I see an approving review. I'm still trying to understand what all of this means. Were the changes made or should I remove the image at the top to be able to merge this?

@sagarpreet-chadha
Copy link
Collaborator

Hey!
No it seems the changes are not made . You can update the PR and then we can merge this :)
Thanks

@rarrunategu1
Copy link
Contributor Author

I've made the changes @sagarpreet-chadha. I appreciate everyone's feedback. It's now ready to merge @jywarren :)

Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !!!

@sagarpreet-chadha sagarpreet-chadha merged commit 15e25f8 into publiclab:master Jun 11, 2019
@welcome
Copy link

welcome bot commented Jun 11, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

jywarren commented Jun 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static HTML mockup of the new "table" Menu in a templates folder
5 participants