docs: create CONTRIBUTING.md #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contributing markdown is intended to serve as a short guide for new contributors. Currently it gives a short description about adding a new layer. Other guidelines can be added to it as well. addresses publiclab#136
grvsachdeva
reviewed
Mar 31, 2019
CONTRIBUTING.md
Outdated
| 3. Here's a codepen example that consists of a base layer and [Luftdaten Layer](https://github.com/publiclab/leaflet-environmental-layers/issues/88) as an overlay. You can check its full implementation [here](https://github.com/publiclab/leaflet-environmental-layers/pull/137). | ||
|
|
||
| ### Some sample PRs to be referred for adding new layers: | ||
| * Osm landfill mine quarry : [#94](https://github.com/publiclab/leaflet-environmental-layers/pull/94) |
There was a problem hiding this comment.
Suggested change
| * Osm landfill mine quarry : [#94](https://github.com/publiclab/leaflet-environmental-layers/pull/94) | |
| * OSM landfill mine quarry : [#94](https://github.com/publiclab/leaflet-environmental-layers/pull/94) |
grvsachdeva
reviewed
Mar 31, 2019
CONTRIBUTING.md
Outdated
|
|
||
| ## Bug reports | ||
|
|
||
| If you are submitting a bug/issue , please go to https://github.com/publiclab/leaflet-environmental-layers/issues/new |
There was a problem hiding this comment.
Suggested change
| If you are submitting a bug/issue , please go to https://github.com/publiclab/leaflet-environmental-layers/issues/new | |
| If you want to submit a bug/issue, please go to https://github.com/publiclab/leaflet-environmental-layers/issues/new |
|
Also, prefer use Fixes #[issue-number] in the issue as that'll close the referenced issue when PR gets merged. Thanks! |
Thanks, I will keep that in mind. |
Changes have been made to the contributing markdown as suggested in review. fixes publiclab#136
jywarren
approved these changes
Apr 8, 2019
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contributing markdown is intended to serve as a short guide for new contributors. Currently it gives a short description about adding a new layer. Other guidelines can be added to it as well.
fixes #136