Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Google Spreadsheet Method #105

Merged
merged 7 commits into from
Dec 12, 2018

Conversation

kevinzluo
Copy link
Contributor

Fixes #102

I have implemented a method that will allow a google spreadsheet (that has been published and made available to anyone online) to be made into a layer.

Using this code:
image

We can do this:
finaltask

This was a fun final task for GCI. Thank you for allowing me to have the chance to complete it 😄 . I will be happy to update the documentation after getting some sleep 💤 .

@jywarren jywarren merged commit e138aa6 into publiclab:master Dec 12, 2018
@jywarren
Copy link
Member

This is awesome. We might now refactor the fractrac spreadsheet layer to use this?

This is worth being its own leaflet library! Maybe we can spin it out and get it listed at leafletjs.org/plugins , and then include it into here w npm!

@jywarren
Copy link
Member

Great work!!!

@kevinzluo
Copy link
Contributor Author

kevinzluo commented Dec 12, 2018

Thank you. Google's api supports even more cool things we can try! I'll look into them once I have more free time. Currently getting ready for exams. If you have time could you look at #96 #98 and #104 ? I think they will make it this repository more friendly to new users. I have also rebased #94 .

Thank you,
Kevin Luo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants