Fixed Service Worker

[harshkhandeparkar]

Fixes #972

Fixed the broken service worker

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[harshkhandeparkar]

@subhahu123 @publiclab/is-reviewers

[aashna27]

Sorry to say but I tried it locally, the changes don't work.

[harshkhandeparkar]

What is the error shown?

[aashna27]

What is the error shown?

[harshkhandeparkar]

So I think the service worker has to be in exmaples/ right?

[harshkhandeparkar]

Ok I'll fix that. Wait a min.

[subhahu123]

Ok I'll fix that. Wait a min.

Can u provide the preview link also
@harshkhandeparkar

[harshkhandeparkar]

Try it out locally now.
@aashna27 @subhahu123

[subhahu123]

Try it out locally now.
@aashna27 @subhahu123

@harshkhandeparkar i think this repo really needs deploy links which automatically generates pr

[harshkhandeparkar]

You are working on it right?

[harshkhandeparkar]

Surge?

[harshithpabbati]

We can use stackblitz for this. We can import code from github from a particular branch and host it we will be getting a link to it. Check this for reference.
https://stackblitz.com/docs

[subhahu123]

@harshithpabbati @harshkhandeparkar we can go for both

[subhahu123]

We can use stackblitz for this. We can import code from github from a particular branch and host it we will be getting a link to it. Check this for reference.
https://stackblitz.com/docs

@harshithpabbati i have use it various time i dont think so that it allows importing projects from gitthub

[subhahu123]

Surge?

@harshkhandeparkar can u work on that please i m working on my gsoc projects

[harshkhandeparkar]

I have exams and I have no experience with it. Sorry.

[harshithpabbati]

If you are busy @harshkhandeparkar then I would like to do that.

[subhahu123]

I have exams and I have no experience with it. Sorry.

me also

[subhahu123]

If you are busy @harshkhandeparkar then I would like to do that.

please go for it @harshithpabbati

[harshkhandeparkar]

Good luck !

[harshithpabbati]

But the case is i don't have experience with it. Fine i will do it somehow.

[subhahu123]

But the case is i don't have experience with it. Fine i will do it somehow.

i don't think so u require any experience with it u can refer to my PR for surge console command

[subhahu123]

But the case is i don't have experience with it. Fine i will do it somehow.

Knowing about the building or compiling of code is enough

[harshkhandeparkar]

But the case is i don't have experience with it. Fine i will do it somehow.

Np, you will only get to learn something new. If at all you get stuck, we are here to help!

[subhahu123]

But the case is i don't have experience with it. Fine i will do it somehow.

Np, you will only get to learn something new. If at all you get stuck, we are here to help!

@harshkhandeparkar u can also provide a preview link for this pr using surge
it is only about three commands and u r done

[harshkhandeparkar]

I am using my phone so I cannot do anything. Srry.

[harshithpabbati]

Was surge implemented anywhere???

[subhahu123]

Was surge implemented anywhere???

community toolbox pr
working properly with no error
publiclab/community-toolbox#147
@harshithpabbati

[harshithpabbati]

Fine cool!

[harshkhandeparkar]

@jywarren this is a small change. Try to merge it.

[aashna27]

I would like to work on surge, is it available?

[harshithpabbati]

I did half of it. You can continue it.
Thanks.

[aashna27]

Okay

[aashna27]

So you create your pr, and then I ll commit my changes and we can get them merged.

[harshithpabbati]

I already opened a pr. #982

[harshkhandeparkar]

@jywarren could you please merge this?

[jywarren]

Ok!!

[harshkhandeparkar]

Thanks a lot!!