Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Crop module #803

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fixes Crop module #803

merged 1 commit into from
Feb 21, 2019

Conversation

aashna27
Copy link

Fixes #800

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@aashna27
Copy link
Author

aashna27 commented Feb 20, 2019

Before :
ezgif com-video-to-gif 3

After:
ezgif com-video-to-gif 4

@jywarren
Copy link
Member

I'll merge this in the meantime, since i'm sorry i got stuck on #778

@jywarren jywarren merged commit cc0c541 into publiclab:main Feb 21, 2019
@aashna27 aashna27 deleted the Crop-module-corrected branch February 21, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants