Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dithering module added #617

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Dithering module added #617

merged 1 commit into from
Jan 6, 2019

Conversation

aashna27
Copy link

@aashna27 aashna27 commented Jan 6, 2019 •
edited
Loading

Fixes #138

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below
    giphy

@aashna27 aashna27 requested review from jywarren and removed request for jywarren January 6, 2019 14:37
@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 6, 2019 •
edited
Loading

Just a suggestion you can use case for algorithm type.

@aashna27 aashna27 requested review from jywarren and tech4GT January 6, 2019 14:54
@aashna27
Copy link
Author

aashna27 commented Jan 6, 2019 •
edited
Loading

Just a suggestion you can use case for algorithm type.

yess but then i ll have to commit again and then squash 😴

@aashna27
Copy link
Author

aashna27 commented Jan 6, 2019

@jywarren please have a look.

@jywarren
Copy link
Member

jywarren commented Jan 6, 2019

This is so cool!!!

@jywarren jywarren merged commit 2aa7e9b into publiclab:main Jan 6, 2019
@aashna27 aashna27 deleted the Dither-Module branch January 6, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

@tech4GT tech4GT Awaiting requested review from tech4GT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashna27 @harshkhandeparkar @jywarren