Added a function to sequencer and then made the functionality available to crop and overlay module. #592

Divy123 · 2019-01-02T18:21:55Z

Fixes #353

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

* Add manifest.json * cache static assets for offline use * update cache * add meta theme-color and change static files to be cache * cache the files on network request * caching on first run Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add a button to clear cache * add styling to clear cache link

I've arranged the modules in alphabetical order.

…ty for crop and overlay modules

This reverts commit dbda25a.

Divy123 · 2019-01-02T18:35:33Z

@tech4GT please review.

jywarren · 2019-01-02T21:23:08Z

src/ImageSequencer.js

@@ -20,6 +20,31 @@ ImageSequencer = function ImageSequencer(options) {
    }
  }

+  function parseInputCoordinates(coord, callback) {


Oh wow, this is really nice! but perhaps a slightly more descriptive function name? What precisely does it do - parseCornerCoordinateInputs?

jywarren · 2019-01-02T21:24:19Z

src/modules/Crop/Module.js

@@ -29,8 +29,23 @@ module.exports = function CropModule(options, UI) {
    // save the input image;
    // TODO: this should be moved to module API to persist the input image
    options.step.input = input.src;
+    var sequencer = require('../../ImageSequencer.js')(options);


ah, we should perhaps try to make this available in a standalone utility file, so in https://github.com/publiclab/image-sequencer/tree/main/src/util, and then directly require it from there, instead of having to instantiate a complete new sequencer?

maybe as https://github.com/publiclab/image-sequencer/tree/main/src/util/parseInputCoordinates.js or whatever you name it!

Sure @jywarren . 😄

Divy123 · 2019-01-03T10:04:06Z

@jywarren I have made the changes . Please review.

jywarren · 2019-01-03T20:16:42Z

src/util/ParseInputCoordinates.js

@@ -0,0 +1,24 @@
+module.exports = function parseCornerCoordinateInputs(options,coord,callback) {


This looks great. Now do you think we might make a unit test for this function, where we also describe what it does using a sentence? This could be quite simple, like this test:

image-sequencer/test/modules/replace.js

Lines 17 to 25 in 6028520

test('replaceImage works.', function (t){

if (typeof(document) === "undefined")

t.end();

sequencer.replaceImage("img","invert",{ callback: function(){

t.equal(0,0, "replaceImage works");

t.end();

} });

});

Sure @jywarren . Will love doing that.

jywarren · 2019-01-03T20:40:07Z

:-)))))

…

On Thu, Jan 3, 2019 at 3:29 PM Slytherin ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/util/ParseInputCoordinates.js <#592 (comment)> : > @@ -0,0 +1,24 @@ +module.exports = function parseCornerCoordinateInputs(options,coord,callback) { Sure @jywarren <https://github.com/jywarren> . Will love doing that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#592 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwRobAjjwoSWk6E7aFMNwDbWQk32ks5u_mgGgaJpZM4ZnB8o> .

Divy123 · 2019-01-04T09:05:54Z

@jywarren I have made a unit test. Please review.

jywarren

This is great. Can we put the test in /test/util?

Divy123 · 2019-01-04T14:35:17Z

@jywarren Test file moved to /test/utils. Please review.

jywarren · 2019-01-04T16:27:04Z

Great!!!!

* updated drop down * fixed greyscale (#593) * add local to locally stored modules (#596) * Add drawing rectangles module (#566) * add drawing rectangle module * changes * White balance module (#585) * white baalance module * improved algorithm * limit check * Ability to set background color when "over cropping" to enlarge canvas (#563) * ability to set background color when over cropping to enlarge canvas * changes * Clarify that saved sequence will only be available in this browser (#587) * clarify that saved sequence will only be available in this browser * changes * changes * changes * Added a function to sequencer and then made the functionality available to crop and overlay module. (#592) * Add manifest.json and cache static assets for offline use (#331) * Add manifest.json * cache static assets for offline use * update cache * add meta theme-color and change static files to be cache * cache the files on network request * caching on first run Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add a button to clear cache * add styling to clear cache link * Update Modules.js (#452) I've arranged the modules in alphabetical order. * Added a function to parse Input coordinates and added the functionality for crop and overlay modules * Added changed dist files * Revert "Added changed dist files" This reverts commit dbda25a. * Changed function name and added the functionaity to src/utils folder * Added unit test * Added unit test to /test/util * Add border thickness and color in DrawRectangle module (#602) * added border thickness functionality * add color functionality

* fixed fastie * fixed greyscale (#593) * add local to locally stored modules (#596) * Add drawing rectangles module (#566) * add drawing rectangle module * changes * White balance module (#585) * white baalance module * improved algorithm * limit check * Ability to set background color when "over cropping" to enlarge canvas (#563) * ability to set background color when over cropping to enlarge canvas * changes * Clarify that saved sequence will only be available in this browser (#587) * clarify that saved sequence will only be available in this browser * changes * changes * changes * Added a function to sequencer and then made the functionality available to crop and overlay module. (#592) * Add manifest.json and cache static assets for offline use (#331) * Add manifest.json * cache static assets for offline use * update cache * add meta theme-color and change static files to be cache * cache the files on network request * caching on first run Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add a button to clear cache * add styling to clear cache link * Update Modules.js (#452) I've arranged the modules in alphabetical order. * Added a function to parse Input coordinates and added the functionality for crop and overlay modules * Added changed dist files * Revert "Added changed dist files" This reverts commit dbda25a. * Changed function name and added the functionaity to src/utils folder * Added unit test * Added unit test to /test/util * Add border thickness and color in DrawRectangle module (#602) * added border thickness functionality * add color functionality * Bump tape from 4.9.1 to 4.9.2 (#579) Bumps [tape](https://github.com/substack/tape) from 4.9.1 to 4.9.2. - [Release notes](https://github.com/substack/tape/releases) - [Commits](tape-testing/tape@v4.9.1...v4.9.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump looks-same from 4.1.0 to 5.0.1 (#559) Bumps [looks-same](https://github.com/gemini-testing/looks-same) from 4.1.0 to 5.0.1. - [Release notes](https://github.com/gemini-testing/looks-same/releases) - [Changelog](https://github.com/gemini-testing/looks-same/blob/master/CHANGELOG.md) - [Commits](gemini-testing/looks-same@v4.1.0...v5.0.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump jsqr from 0.2.2 to 1.1.1 (#532) Bumps [jsqr](https://github.com/cozmo/jsQR) from 0.2.2 to 1.1.1. - [Release notes](https://github.com/cozmo/jsQR/releases) - [Commits](https://github.com/cozmo/jsQR/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update color drop down (#595) * updated drop down * fixed greyscale (#593) * add local to locally stored modules (#596) * Add drawing rectangles module (#566) * add drawing rectangle module * changes * White balance module (#585) * white baalance module * improved algorithm * limit check * Ability to set background color when "over cropping" to enlarge canvas (#563) * ability to set background color when over cropping to enlarge canvas * changes * Clarify that saved sequence will only be available in this browser (#587) * clarify that saved sequence will only be available in this browser * changes * changes * changes * Added a function to sequencer and then made the functionality available to crop and overlay module. (#592) * Add manifest.json and cache static assets for offline use (#331) * Add manifest.json * cache static assets for offline use * update cache * add meta theme-color and change static files to be cache * cache the files on network request * caching on first run Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add a button to clear cache * add styling to clear cache link * Update Modules.js (#452) I've arranged the modules in alphabetical order. * Added a function to parse Input coordinates and added the functionality for crop and overlay modules * Added changed dist files * Revert "Added changed dist files" This reverts commit dbda25a. * Changed function name and added the functionaity to src/utils folder * Added unit test * Added unit test to /test/util * Add border thickness and color in DrawRectangle module (#602) * added border thickness functionality * add color functionality * rebuild

Mridul97 and others added 6 commits October 26, 2018 13:58

Update Modules.js (#452)

4d996b9

I've arranged the modules in alphabetical order.

Added a function to parse Input coordinates and added the functionali…

7887e54

…ty for crop and overlay modules

Resolved Merge conflicts

735c0b5

Added changed dist files

dbda25a

Revert "Added changed dist files"

10110b1

This reverts commit dbda25a.

jywarren reviewed Jan 2, 2019

View reviewed changes

divy123 added 2 commits January 3, 2019 15:22

Changed function name and added the functionaity to src/utils folder

16ed031

Merge remote-tracking branch 'upstream/main' into parse-input

8c59321

jywarren reviewed Jan 3, 2019

View reviewed changes

Added unit test

6ef8b7a

jywarren requested changes Jan 4, 2019

View reviewed changes

Added unit test to /test/util

35f7605

jywarren approved these changes Jan 4, 2019

View reviewed changes

jywarren merged commit aad1f82 into publiclab:main Jan 4, 2019

jywarren mentioned this pull request Jan 4, 2019

Uncaught TypeError: parseCoordInputs.parseCornerCoordinateInputs is not a function #606

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a function to sequencer and then made the functionality available to crop and overlay module. #592

Added a function to sequencer and then made the functionality available to crop and overlay module. #592

Divy123 commented Jan 2, 2019 •

edited

Loading

Divy123 commented Jan 2, 2019

jywarren Jan 2, 2019

jywarren Jan 2, 2019

jywarren Jan 2, 2019

Divy123 Jan 3, 2019

Divy123 commented Jan 3, 2019

jywarren Jan 3, 2019

Divy123 Jan 3, 2019

jywarren commented Jan 3, 2019 via email

Divy123 commented Jan 4, 2019

jywarren left a comment

Divy123 commented Jan 4, 2019

jywarren commented Jan 4, 2019

		@@ -0,0 +1,24 @@
		module.exports = function parseCornerCoordinateInputs(options,coord,callback) {

	test('replaceImage works.', function (t){
	if (typeof(document) === "undefined")
	t.end();

	sequencer.replaceImage("img","invert",{ callback: function(){
	t.equal(0,0, "replaceImage works");
	t.end();
	} });
	});

Added a function to sequencer and then made the functionality available to crop and overlay module. #592

Added a function to sequencer and then made the functionality available to crop and overlay module. #592

Conversation

Divy123 commented Jan 2, 2019 • edited Loading

Divy123 commented Jan 2, 2019

jywarren Jan 2, 2019

Choose a reason for hiding this comment

jywarren Jan 2, 2019

Choose a reason for hiding this comment

jywarren Jan 2, 2019

Choose a reason for hiding this comment

Divy123 Jan 3, 2019

Choose a reason for hiding this comment

Divy123 commented Jan 3, 2019

jywarren Jan 3, 2019

Choose a reason for hiding this comment

Divy123 Jan 3, 2019

Choose a reason for hiding this comment

jywarren commented Jan 3, 2019 via email

Divy123 commented Jan 4, 2019

jywarren left a comment

Choose a reason for hiding this comment

Divy123 commented Jan 4, 2019

jywarren commented Jan 4, 2019

Divy123 commented Jan 2, 2019 •

edited

Loading