Colormap fixes!

[jywarren]

fixes #332 !!! @MargaretAN9

[MargaretAN9]

please tell me if I need to do anything

[jywarren]

Nope just let these tests run!!!! Glad to see you!!

…

On Sat, Nov 17, 2018, 12:56 AM MargaretAN9 ***@***.*** wrote: please tell me if I need to do anything — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#475 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-jSY1zY7C5qplauApYyrSbBtybJks5uv6TegaJpZM4YnS2P> .

[jywarren]

Did u see the progress on the opencv module? Exciting

…

On Sat, Nov 17, 2018, 12:56 AM Jeffrey Warren ***@***.*** wrote: Nope just let these tests run!!!! Glad to see you!! On Sat, Nov 17, 2018, 12:56 AM MargaretAN9 ***@***.*** wrote: > please tell me if I need to do anything > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#475 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABfJ-jSY1zY7C5qplauApYyrSbBtybJks5uv6TegaJpZM4YnS2P> > . >

[MargaretAN9]

not yet will check it out

[jywarren]

ok had to compile this wtih grunt build and pushed up the files

[jywarren]

OK, rebased, rebuilt, and one more test run but i'll go to sleep now and merge in the morning! Good night!!!

[MargaretAN9]

Cool will check on it Sat

[jywarren]

Oops, forgot to add the new colormaps to the interface! Did that in an extra commit:

[jywarren]

and this is ready to merge once this passes, finally! Thanks SO MUCH for your work on this, it's tremendous. Next step could be to develop a sequencer string which would output a sample 1x100 px strip for each map, so we could show them visually in the interface!

[jywarren]

it could be substantially based on the colorbar module!

[jywarren]

So nice!!!

[jywarren]

[MargaretAN9]

@jywarren
-Checked on the 7 colormaps, 5 out of 7 are good
-2 need updates, greyscale and fastie, not sure how the error was introduced since they were fine in the original code. This is easy to fix by going back to prior code. Should I submit a request?
-there should be 8 colormaps in all, 'bluwhtgrngis' was not added to the list,
-will make a post with the same picture using the different colormaps when they are complete

[jywarren]

oh ok, sorry i must've missed one, and hope i didn't introduce an error in the others. Yes please submit a new PR! Try also running `grunt build` on your work once you do, so it gets compiled. Thanks, and great work!

…

On Sun, Nov 18, 2018 at 12:48 AM MargaretAN9 ***@***.***> wrote: @jywarren <https://github.com/jywarren> -Checked on the 7 colormaps, 5 out of 7 are good -2 need updates, greyscale and fastie, not sure how the error was introduced since they were fine in the original code. This is easy to fix by going back to prior code. Should I submit a request? -there should be 8 colormaps in all, 'bluwhtgrngis' was not added to the list, -will make a post with the same picture using the different colormaps when they are complete — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#475 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJxe-NXMiXEgesKR22_u-ypk2jgYDks5uwPSAgaJpZM4YnS2P> .