Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-button-dim #310

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Add-button-dim #310

merged 1 commit into from
Jul 24, 2018

Conversation

kevinkmmak
Copy link

Dim the button onLoad, then enable it when something is selected.

Dim the button onLoad, then enable it when selected.
@jywarren jywarren requested a review from tech4GT July 23, 2018 22:42
Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinkmmak Can you please attach a screenshot of this, just be double sure!! Thanks😁

@kevinkmmak
Copy link
Author

Sure, here you are.
screen shot 2018-07-24 at 10 03 09 pm
screen shot 2018-07-24 at 10 03 40 pm

Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work🎉🎉

@kevinkmmak
Copy link
Author

Thank you. Afterall, this is my first real contribution. I am now confident to look for more issues that I can contribute. Thank you again for opening this first-timer-only issue.

@tech4GT
Copy link
Member

tech4GT commented Jul 24, 2018

@jywarren this ready to be merged in😄

@tech4GT
Copy link
Member

tech4GT commented Jul 24, 2018

Welcome to our community @kevinkmmak😄🎉

@jywarren jywarren merged commit 56feb4c into publiclab:master Jul 24, 2018
@jywarren
Copy link
Member

Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants