Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed buggy file upload container #1841

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fixed buggy file upload container #1841

merged 2 commits into from
Mar 12, 2021

Conversation

waridrox
Copy link
Member

@waridrox waridrox commented Mar 11, 2021

Fixes #1840

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

@waridrox waridrox requested a review from a team as a code owner March 11, 2021 14:28
@welcome
Copy link

welcome bot commented Mar 11, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
Also please refer (https://github.com/publiclab/image-sequencer/blob/main/README.md) for installation help.

@gitpod-io
Copy link

gitpod-io bot commented Mar 11, 2021

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is great. Are you basically driving everything in JS now to get past the issue? Thanks!

@waridrox
Copy link
Member Author

Oh this is great. Are you basically driving everything in JS now to get past the issue? Thanks!

Yes sir, absolutely 😄

@jywarren jywarren merged commit 417c1b1 into publiclab:main Mar 12, 2021
@welcome
Copy link

welcome bot commented Mar 12, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@jywarren
Copy link
Member

Fantastic work, thank you!!!!!

@waridrox waridrox deleted the containerFix branch March 14, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the drag and drop functionality container
2 participants