Added options startingX and startingY in Add-Qr Module

[root00198]

Added startingX and startingY for the QR Code Module.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

Merging #1520 into main will increase coverage by 0.07%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   66.71%   66.79%   +0.07%     
==========================================
  Files         129      129              
  Lines        2668     2671       +3     
  Branches      430      430              
==========================================
+ Hits         1780     1784       +4     
+ Misses        888      887       -1

Impacted Files	Coverage Δ
src/modules/_nomodule/PixelManipulation.js	46.15% <100%> (+0.41%)	⬆️
src/modules/TextOverlay/Module.js	46.15% <20%> (-8.4%)	⬇️
src/modules/Histogram/Module.js	100% <0%> (+2.7%)	⬆️
src/modules/Threshold/Threshold.js	83.72% <0%> (+4.65%)	⬆️

[root00198]

@publiclab/is-reviewers

[harshkhandeparkar]

Waiting for the tests...

[rishabhshuklax]

What if user inputs value for X=1000 for a 600x500 image, the QR will be generated outside the image, maybe you can fix that!

[root00198]

@blurry-x-face, technically it should be generated outside the image(means no qr code image should be generated), and for loop will restrict the creation of QR code in that case.

[rishabhshuklax]

@blurry-x-face, technically it should be generated outside the image(means no qr code image should be generated), and for loop will restrict the creation of QR code in that case.

In that case maybe we can just generate the QR at the corner? What do you think?

[root00198]

The fact is that maybe someone wants only half a qr code, I feel like by not sticking the qr at the end, we are giving a feature rather than a limitation.

[rishabhshuklax]

Why would someone want only half a QR code? what are your thoughts @harshkhandeparkar

[root00198]

@blurry-x-face, now I feels like you are right. Maybe fixing the qr code at the end is better. I will create the changes soon.

[root00198]

[rishabhshuklax]

Nice! 🎉

[jywarren]

Really nice! Thank you!