circular gradient module

[niravasher]

#869

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[niravasher]

fixing some previously remaining bugs. @harshkhandeparkar

[codecov]

Codecov Report

Merging #1496 into main will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             main    #1496   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files         130      130           
  Lines        2682     2682           
  Branches      432      432           
=======================================
  Hits         1790     1790           
  Misses        892      892

Impacted Files	Coverage Δ
src/modules/DrawRectangle/DrawRectangle.js	100% <100%> (ø)	⬆️

[root00198]

Insted of creating a new module, we can give 'Circular' option in the gradient module.

[niravasher]

Ok! Will do that @root00198

[root00198]

It's just an idea, Let a reviewer comment on it, before you start working....

[niravasher]

Okay

[harshkhandeparkar]

Insted of creating a new module, we can give 'Circular' option in the gradient module.

Nice idea!

[niravasher]

@root00198 @harshkhandeparkar PR updated. Please review

[jywarren]

This looks really cool. Thank you! Do you think you could add a module test for this, to protect the functionality? 🎉

[niravasher]

Yes, will do that @jywarren

[niravasher]

Benchmark is the datauri of the circular gradient

options = { gradientType = circular } testModule('gradient', options, benchmark);
What is the cmd to test only one module? @jywarren @harshkhandeparkar

[harshkhandeparkar]

Only one module meaning? I didn't get you. What are you trying to do?

[niravasher]

Ahh, done. Should I open up a new PR for this or update this one? @jywarren @harshkhandeparkar

[root00198]

update this one

[niravasher]

Please merge this PR, I write test in a follow up PR. I am stuck with some merge conflicts @jywarren

[harshkhandeparkar]

Try to solve the conflicts. This will help you in the future.

[niravasher]

This module is complete with test. Please review and merge this. @jywarren @root00198

[niravasher]

Please merge this PR @jywarren

[jywarren]

Awesome!!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!