Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Average module editing the UI from the source #1469

Merged
merged 10 commits into from
Jan 16, 2020

Conversation

root00198
Copy link
Member

Fixes #1467 (<=== Replace 0000 with the Issue Number)

output

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #1469 into main will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1469     +/-   ##
=========================================
+ Coverage   64.77%   65.27%   +0.5%     
=========================================
  Files         127      126      -1     
  Lines        2603     2595      -8     
  Branches      418      416      -2     
=========================================
+ Hits         1686     1694      +8     
+ Misses        917      901     -16
Impacted Files Coverage Δ
src/modules/Contrast/Module.js 100% <100%> (ø) ⬆️
src/ui/LoadImage.js 59.09% <0%> (+9.09%) ⬆️
src/modules/ImportImage/Module.js 87.5% <0%> (+75%) ⬆️

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking good!

src/modules/Average/Module.js Outdated Show resolved Hide resolved
src/modules/Average/Module.js Show resolved Hide resolved
@jywarren jywarren merged commit 5ae5459 into publiclab:main Jan 16, 2020
@jywarren
Copy link
Member

Nice work, thank you!!!

@root00198 root00198 deleted the issue#1467 branch January 17, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Average Module Directly changes the UI
3 participants