-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding easier to use interface for blend module and different blend modes #1453
Conversation
Bumps [data-uri-to-buffer](https://github.com/TooTallNate/node-data-uri-to-buffer) from 2.0.1 to 3.0.0. - [Release notes](https://github.com/TooTallNate/node-data-uri-to-buffer/releases) - [Commits](TooTallNate/node-data-uri-to-buffer@2.0.1...3.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@publiclab/is-reviewers @jywarren please review this |
If anyone has any idea for some other blend mode too I'd be happy to work on it! |
I believe this is some literally great work @blurry-x-face . Blend module goes wowyyy. |
What about the tests? Why are they failing? |
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 66.64% 66.62% -0.02%
==========================================
Files 128 129 +1
Lines 2659 2661 +2
Branches 426 428 +2
==========================================
+ Hits 1772 1773 +1
- Misses 887 888 +1
|
I've fixed the problem please re-review @Divy123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a compulsory suggestion but would you like to add some docs about the different blend modules in the modules.md
file? Or at least add links to say Wikipedia sources about the blend modes.
@harshkhandeparkar I have added link to the source in the Module.js. |
@jywarren @harshkhandeparkar Can you please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Oh goodness, i had missed this! It's really amazing!!!! 🎉 🎉 Great work!!! |
b1 = p.get(x, y, 2), | ||
a1 = p.get(x, y, 3); | ||
|
||
const blends = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
🎉 🙌 😄 |
Fixes #1452
This PR adds support for following blend modes:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowSample: