-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Dynamic module #1451
Fix for Dynamic module #1451
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 65.55% 65.57% +0.01%
==========================================
Files 128 128
Lines 2619 2626 +7
Branches 421 424 +3
==========================================
+ Hits 1717 1722 +5
- Misses 902 904 +2
|
@publiclab/is-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Does it still let the user set values for r, g, and b as expected?
Yes, it still let user set those values... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Do you think you could write a simple module test to ensure this fix is preserved in the future?
Thanks for your help!
A test for this module alredy exist, its options were set in such a way that previously the test passes, and there was no issue. The test is well written. |
Fantastic. Thank you!! |
Issues in Dynamic Modules :
There is a input by name
monochrome (fallback)
whose description isExpression to return with R, G, B, and A inputs; fallback for other channels if none provided
. But when the inputs for Red, Green, Blue are not provided it should consider the default values, which it is not and hence creating issues like :- 'BEFORE FIX
AFTER FIX
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!