Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Dynamic module #1451

Merged
merged 5 commits into from
Jan 16, 2020
Merged

Fix for Dynamic module #1451

merged 5 commits into from
Jan 16, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Jan 10, 2020

Issues in Dynamic Modules :

There is a input by name monochrome (fallback) whose description is Expression to return with R, G, B, and A inputs; fallback for other channels if none provided. But when the inputs for Red, Green, Blue are not provided it should consider the default values, which it is not and hence creating issues like :- '

  • The command line interface not working and shows a black image.
    BEFORE FIX
    cli-not-working
    AFTER FIX
    cli-working

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #1451 into main will increase coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   65.55%   65.57%   +0.01%     
==========================================
  Files         128      128              
  Lines        2619     2626       +7     
  Branches      421      424       +3     
==========================================
+ Hits         1717     1722       +5     
- Misses        902      904       +2
Impacted Files Coverage Δ
src/modules/Overlay/Module.js 94.87% <71.42%> (-5.13%) ⬇️

@root00198
Copy link
Member Author

root00198 commented Jan 10, 2020

@publiclab/is-reviewers

Copy link
Member

@anthony-zhou anthony-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Does it still let the user set values for r, g, and b as expected?

@root00198
Copy link
Member Author

Yes, it still let user set those values...

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Do you think you could write a simple module test to ensure this fix is preserved in the future?

Thanks for your help!

@root00198
Copy link
Member Author

root00198 commented Jan 16, 2020

A test for this module alredy exist, its options were set in such a way that previously the test passes, and there was no issue. The test is well written.

@jywarren jywarren merged commit 9a2f4c1 into publiclab:main Jan 16, 2020
@jywarren
Copy link
Member

Fantastic. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants