Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta module bug #1426

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Conversation

rishabhshuklax
Copy link
Member

Fixes #1239

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #1426 into main will decrease coverage by 0.01%.
The diff coverage is 45.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   66.36%   66.35%   -0.02%     
==========================================
  Files         125      125              
  Lines        2572     2574       +2     
  Branches      406      406              
==========================================
+ Hits         1707     1708       +1     
- Misses        865      866       +1
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø) ⬆️
examples/lib/insertPreview.js 13.51% <0%> (ø) ⬆️
examples/lib/intermediateHtmlStepUi.js 11.11% <0%> (ø) ⬆️
src/modules/EdgeDetect/Module.js 96.15% <100%> (ø) ⬆️
src/modules/EdgeDetect/EdgeUtils.js 86.95% <100%> (ø) ⬆️
src/modules/ColorTemperature/Module.js 84.21% <100%> (ø) ⬆️
src/modules/Blur/Blur.js 100% <100%> (ø) ⬆️
examples/lib/defaultHtmlStepUi.js 11.29% <4.16%> (+0.44%) ⬆️
examples/lib/mapHtmltypes.js 8% <50%> (ø) ⬆️
... and 7 more

@keshav234156
Copy link
Member

@blurry-x-face can you please upload a gif

@rishabhshuklax
Copy link
Member Author

Peek 2020-01-06 19-45

@Divy123
Copy link
Member

Divy123 commented Jan 6, 2020

Great I think this is good to go.

@keshav234156
Copy link
Member

Nicely Done!!!

@jywarren
Copy link
Member

jywarren commented Jan 6, 2020

Awesome. Thanks! And hi, @Divy123 !!!

@jywarren jywarren merged commit 6420bb0 into publiclab:main Jan 6, 2020
@rishabhshuklax rishabhshuklax deleted the create-meta-module branch January 6, 2020 22:11
@Divy123
Copy link
Member

Divy123 commented Jan 8, 2020

Hi @jywarren !! How are you?

@jywarren
Copy link
Member

jywarren commented Jan 8, 2020

Great!!! So good to hear from you. I got your email, i'm just behind a bit as usual 😅

@Divy123
Copy link
Member

Divy123 commented Jan 8, 2020

No probs !! So good to be back here. And definitely missing our weekly calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with meta-modules
4 participants