-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug => Color Temperature showing black image when set on default. #1401
Fixed bug => Color Temperature showing black image when set on default. #1401
Conversation
as far as I can see the error in the travis ci build is |
@publiclab/is-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please load the default temperature from the info.json file? We have a util function than could help you here src/util/loadDefaults.js
. Also, you don't need to add the ===
you can just write
options.temperature = options.temperature || defaults.temperature;
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 66.16% 66.16%
=======================================
Files 125 125
Lines 2574 2574
Branches 406 406
=======================================
Hits 1703 1703
Misses 871 871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀! Thanks for your contribution.
This is super!!! Thanks a lot!!! |
Fixes #1392 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!