-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed redirect from '/' to reload the same page #1399
Conversation
@publiclab/is-reviewers |
Codecov Report
@@ Coverage Diff @@
## main #1399 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 125 125
Lines 2571 2571
Branches 404 404
=======================================
Hits 1700 1700
Misses 871 871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for your help. I think what you did was perfect for this use case. But don't you think to add a new function could have helped in some other use cases?
Hey @root00198, could you create a feature branch for the PR? This will allow you to work on multiple features at once, otherwise, you have to wait for the previous PR to be merged so that main becomes free for the new branch and so on. |
Let them start doing this from the next PR since this one is ready to be merged. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you so much! This is great!!! |
Fixes #1394 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!