add tests for bottom step button

[pythongiant]

concerns #1369 (<=== Replace 0000 with the Issue Number)

Hi, I have completed task 1 specified in #1369

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

[welcome]

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[pythongiant]

Huh Travis Failed but locally my tests worked

[codecov]

Codecov Report

Merging #1387 into main will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <ø> (ø)	⬆️
examples/lib/insertPreview.js	13.51% <0%> (ø)	⬆️
examples/lib/intermediateHtmlStepUi.js	11.11% <0%> (ø)	⬆️
examples/lib/defaultHtmlStepUi.js	10.73% <0%> (ø)	⬆️
src/modules/EdgeDetect/Module.js	96.15% <100%> (ø)	⬆️
src/modules/EdgeDetect/EdgeUtils.js	86.95% <100%> (ø)	⬆️
examples/lib/mapHtmltypes.js	8% <100%> (ø)	⬆️
src/modules/Blur/Blur.js	100% <100%> (ø)	⬆️

[pythongiant]

@keshav234156 @debck @ananyaarun

[pythongiant]

CC: @jywarren

[pythongiant]

Works now

[debck]

Also, change in the PR description from Fixes to concerns so that merging this doesn't close the issue.

[keshav234156]

@pythongiant This is testing radio button not the add step.For that choose some different value which is not present in radio group

[keshav234156]

@pythongiant look good now you have check src of the first image is different from the second image so that it assures us that different step is being added. You can do it with
expect($('.step:last img')[0].src).not.toEqual($('.step:first img')[0].src);
with small changes as required .

This won't work for the blend as steps have to be greater than 2 otherwise src of both would be equal. So change to some other module like blur.

[pythongiant]

@keshav234156 i have done the required changes. Check it out now?

[keshav234156]

@pythongiant Great !!!you finally did it.

[pythongiant]

@debck accept and merge?

[debck]

Great Work 🎉

[pythongiant]

@jywarren merge?

[harshkhandeparkar]

This isn't a change request but it would be good if you add some comments and leave empty lines to increase readability. Otherwise, it is all good.

[pythongiant]

@harshkhandeparkar I have refactored the code a bit, check it out?

[keshav234156]

@pythongiant Please do the changes as requested by @harshkhandeparkar

[pythongiant]

@keshav234156 check it out?

[harshkhandeparkar]

Also, I don't think you need the extra images. What generated those?

[pythongiant]

@harshkhandeparkar fixed it!

[harshkhandeparkar]

Awesome!

[jywarren]

So awesome! Thanks, just syncing and hopefully we'll merge this next!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

[jywarren]

Fantastic!!