-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCI] Standardised Blur module code comments #1347
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1347 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 125 125
Lines 2571 2571
Branches 404 404
=======================================
Hits 1700 1700
Misses 871 871
|
@SidharthBansal please try to get these PRs merged quickly. I don't think I will be free next month so I want to complete as many tasks as possible this month itself. Thanks! |
@harshkhandeparkar I will be reviewing PRs from next week. But please be patient, as we have to make it feasible for all the mentors and participants to participate smoothly, we will try our level best. Next thing is I think Siddharth will be doing it whenever he will be here,and we have to make it open for all. So we cannot make it a personalized experience for someone. |
@Divy123 yeah sure. I am in a hurry because the task I have already accepted is about to hit the deadline and also I hadn't expected it to take such a long time. Sorry if I am causing inconvenience to others. If I had known that I would have to split this task or if the task had been split earlier, I would have left it to claim at the end or let someone else claim it. Sorry still. |
My school schedule is going to be busy now on. This is the only month when I got a bit of free time. Otherwise, I wouldn't even have participated. |
I can review your prs tomorrow. I am busy today. He is assigned one hall-of-fame task. I asked him to divide it into multiple PRs so that we can review it easy. |
Codeclimate is failing please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Is there a reason why you closed the PR? |
By mistake
…On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar ***@***.***> wrote:
Is there a reason why you closed the PR?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA>
.
|
Please open it
On Mon, Dec 9, 2019 at 11:31 PM Sidharth Bansal <
bansal.sidharthcode@gmail.com> wrote:
… By mistake
On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar <
***@***.***> wrote:
> Is there a reason why you closed the PR?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA>
> .
>
|
Ohk.
On Mon, 9 Dec, 2019, 11:31 PM Sidharth Bansal, <notifications@github.com>
wrote:
… By mistake
On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar <
***@***.***>
wrote:
> Is there a reason why you closed the PR?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <
#1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347?email_source=notifications&email_token=AIJI5HYPSKNV2Y2PVCA3C7LQX2BXHA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKCRFQ#issuecomment-563357846>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5H7SBHLXKZ2HUGFMVX3QX2BXHANCNFSM4JYKPFVA>
.
|
@jywarren can this and the other comments GCI PRs be merged now? |
Yes! Let's rebase and we should be good to go! Thanks!! |
Thank you!
…On Sat, 21 Dec, 2019, 10:30 PM Jeffrey Warren, ***@***.***> wrote:
Yes! Let's rebase and we should be good to go! Thanks!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347?email_source=notifications&email_token=AIJI5H5VSHV43HTUB77LUQLQZZDRBA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO7V5Y#issuecomment-568195831>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5HYT7E6VDPDXNG53RSLQZZDRBANCNFSM4JYKPFVA>
.
|
Hmm, do you know what these errors are? Thanks! |
I'm not sure. Gifshot does use canvas but these tests don't run on GIFs so
there is no question of Gifshot. But these errors are definitely related to
canvas.
Perhaps one of the modules which requires canvas doesn't check for the
`inBrowser` flag...
…On Wed, 1 Jan, 2020, 10:24 PM Jeffrey Warren, ***@***.***> wrote:
Hmm, do you know what these errors are? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1347?email_source=notifications&email_token=AIJI5H3DXWIDRX5CVLW6TW3Q3TDCVA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5IR4Y#issuecomment-570067187>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5H2VGM6TJ53UK73PT2LQ3TDCVANCNFSM4JYKPFVA>
.
|
@jywarren it seem like it was some travis fault.Now it's fine. |
Looking to merge this one next after updating branch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!!
Fixes #1342 (<=== Replace
0000
with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!