-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cursor change into pointer #1259
Conversation
Thanks for opening this pull request! |
@jywarren Please review. |
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 32.05% 32.07% +0.01%
==========================================
Files 107 107
Lines 1987 1986 -1
Branches 296 297 +1
==========================================
Hits 637 637
+ Misses 1350 1349 -1
|
@harshkhandeparkar @Divy123 @jywarren Please review. |
@samagragupta do you have GIF (s)/screenshot (s). Several ones would be nice (for different parts). Thank you! |
@harshkhandeparkar Done |
👍 LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution to this repo!
@publiclab/is-reviewers @jywarren can you please review the PR |
Looks great! Sorry for slow response - i just resolved conflicts and if it passes, I'll merge! |
@jywarren It passed 😄 |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Great! Thanks a lot! |
Fixes #913
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!