Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor change into pointer #1259

Merged
merged 2 commits into from
Oct 1, 2019
Merged

cursor change into pointer #1259

merged 2 commits into from
Oct 1, 2019

Conversation

samagragupta
Copy link
Member

Fixes #913

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Sep 22, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@samagragupta
Copy link
Member Author

@jywarren Please review.

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #1259 into main will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   32.05%   32.07%   +0.01%     
==========================================
  Files         107      107              
  Lines        1987     1986       -1     
  Branches      296      297       +1     
==========================================
  Hits          637      637              
+ Misses       1350     1349       -1
Impacted Files Coverage Δ
examples/lib/defaultHtmlStepUi.js 12.19% <ø> (ø) ⬆️
src/modules/Rotate/Module.js 20.83% <0%> (+0.83%) ⬆️

@samagragupta
Copy link
Member Author

@harshkhandeparkar @Divy123 @jywarren Please review.

@harshkhandeparkar
Copy link
Member

@samagragupta do you have GIF (s)/screenshot (s). Several ones would be nice (for different parts).

Thank you!

@samagragupta
Copy link
Member Author

@harshkhandeparkar Done
123
4

@harshkhandeparkar
Copy link
Member

👍 LGTM

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution to this repo!

@samagragupta
Copy link
Member Author

@publiclab/is-reviewers @jywarren can you please review the PR

@jywarren
Copy link
Member

jywarren commented Oct 1, 2019

Looks great! Sorry for slow response - i just resolved conflicts and if it passes, I'll merge!

@samagragupta
Copy link
Member Author

@jywarren It passed 😄

@jywarren jywarren merged commit 44f5cb4 into publiclab:main Oct 1, 2019
@welcome
Copy link

welcome bot commented Oct 1, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Oct 1, 2019

Great! Thanks a lot!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cursor should change into pointer
3 participants