-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphabetically arranged the MODULES.md file #1167 - Sorted index and the corpus #1186
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 55.31% 55.31%
=======================================
Files 116 116
Lines 2381 2381
Branches 364 364
=======================================
Hits 1317 1317
Misses 1064 1064 |
docs/MODULES.md
Outdated
34. [Saturation](#saturation-module) | ||
35. [Segmented-Colormap](#segmented-colormap-module) | ||
36. [Threshold](#threshold) | ||
37. [Tint](#tint) | ||
38. [Text-Overlay](#text-overlay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey your work is really great just a little change can you change the order for text overlay after segmented? Sorry for the trouble
Hey I did make changes and pushed them. Did you receive anything? |
Hey yeah cool, the changes exist!! Hooray great work |
@publiclab/reviewers let's have a look and approve this to get it merged at the earliest! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @kirito-k
I guess only @jywarren can merge this so once he comes next friday this pr can be prioritised to be merged first. |
@aashna27 Thank you so much. :) |
@jywarren this can be merged. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Great work! Thanks so much!!! |
…the corpus (#1186) * Sorted index and the corpus * Changed text overlay sequence
Fixes #1167
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!