Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Module.js #1090

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Update Module.js #1090

merged 2 commits into from
Aug 30, 2019

Conversation

tudoranghelina91
Copy link

Added const $ = window.$; at line 19 inside extraManipulation(pixels)

Fixes #0000 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Added const $ = window.$; at line 19 inside extraManipulation(pixels)
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #1090 into main will decrease coverage by 23.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1090       +/-   ##
===========================================
- Coverage   55.11%   32.07%   -23.05%     
===========================================
  Files         117      107       -10     
  Lines        2344     1986      -358     
  Branches      360      297       -63     
===========================================
- Hits         1292      637      -655     
- Misses       1052     1349      +297
Impacted Files Coverage Δ
src/modules/Average/Module.js 36.36% <100%> (-63.64%) ⬇️
src/modules/Overlay/Module.js 12.5% <0%> (-87.5%) ⬇️
src/modules/Gradient/Module.js 10% <0%> (-83.34%) ⬇️
src/modules/DecodeQr/Module.js 16.66% <0%> (-83.34%) ⬇️
src/modules/Crop/Module.js 8.69% <0%> (-82.61%) ⬇️
src/modules/Exposure/Module.js 22.22% <0%> (-77.78%) ⬇️
src/modules/EdgeDetect/Module.js 19.23% <0%> (-76.93%) ⬇️
src/modules/Brightness/Module.js 23.52% <0%> (-76.48%) ⬇️
src/modules/Convolution/Module.js 23.52% <0%> (-76.48%) ⬇️
src/modules/Blur/Module.js 25% <0%> (-75%) ⬇️
... and 27 more

Copy link

@aashna27 aashna27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jywarren jywarren merged commit 3741d67 into publiclab:main Aug 30, 2019
@welcome
Copy link

welcome bot commented Aug 30, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Thank you!!!

keshav234156 added a commit that referenced this pull request Nov 2, 2019
jywarren pushed a commit that referenced this pull request Dec 16, 2019
Added const $ = window.$; at line 19 inside extraManipulation(pixels)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants