Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unresponsive webcam preview window #1047

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

Sanscripter
Copy link

@Sanscripter Sanscripter commented Apr 27, 2019

Fixes #951

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 27, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #1047 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files         102      102           
  Lines        1942     1942           
  Branches      297      297           
=======================================
  Hits          691      691           
  Misses       1251     1251

Copy link

@harshithpabbati harshithpabbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! @Sanscripter

@harshithpabbati
Copy link

And mention this in comment @publiclab/is-reviewers to get it reviewed.
Thanks

@Divy123
Copy link
Member

Divy123 commented Apr 27, 2019

Please provide a gif!!

@Sanscripter
Copy link
Author

@Divy123
ezgif-1-743ab989e57b

@aashna27
Copy link

Cool, this is great! 👍 Thanks and welcome to the community!! 🙂

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your contribution 🚀

@Divy123
Copy link
Member

Divy123 commented Apr 28, 2019

Awesome this is great and ready to be merged!!
Thanks a lot for this and welcome to Public Lab community!!
We would love to keep having your contributions !!

@Divy123
Copy link
Member

Divy123 commented Apr 28, 2019

@jywarren please have a look!!

@jywarren jywarren merged commit 5566152 into publiclab:main Apr 29, 2019
@welcome
Copy link

welcome bot commented Apr 29, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome work, everyone!!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webcam preview moves to the side.
6 participants