-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unresponsive webcam preview window #1047
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1047 +/- ##
=======================================
Coverage 35.58% 35.58%
=======================================
Files 102 102
Lines 1942 1942
Branches 297 297
=======================================
Hits 691 691
Misses 1251 1251 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work! @Sanscripter
And mention this in comment @publiclab/is-reviewers to get it reviewed. |
Please provide a gif!! |
Cool, this is great! 👍 Thanks and welcome to the community!! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for your contribution 🚀
Awesome this is great and ready to be merged!! |
@jywarren please have a look!! |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Awesome work, everyone!!!! 🎉 |
Fixes #951
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!