Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta description with keywords for SEO #1018

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Apr 16, 2019

Fixes #978

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #1018 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   34.08%   34.08%           
=======================================
  Files          97       97           
  Lines        1778     1778           
  Branches      278      278           
=======================================
  Hits          606      606           
  Misses       1172     1172

@Divy123
Copy link
Member Author

Divy123 commented Apr 16, 2019

@jywarren please have a look!!
I have added meta description for SEO.
Also its great to see the code coverage report.
Thanks for that!!

@Divy123
Copy link
Member Author

Divy123 commented Apr 18, 2019

@jywarren please review !!

@jywarren
Copy link
Member

Did you test this out locally? I see a few HTML changes and just want to be sure. Thanks!!!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you beautify the file or something?

@Divy123
Copy link
Member Author

Divy123 commented Apr 18, 2019 via email

@Divy123
Copy link
Member Author

Divy123 commented Apr 18, 2019

@jywarren Actually those are some linting changes, not the code ones.
I think we can merge this.

@jywarren jywarren merged commit 84aede7 into publiclab:main Apr 18, 2019
@jywarren
Copy link
Member

Awesome, thanks all!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Does Not Have A Meta Description
4 participants