-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta description with keywords for SEO #1018
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 34.08% 34.08%
=======================================
Files 97 97
Lines 1778 1778
Branches 278 278
=======================================
Hits 606 606
Misses 1172 1172 |
@jywarren please have a look!! |
@jywarren please review !! |
Did you test this out locally? I see a few HTML changes and just want to be sure. Thanks!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you beautify the file or something?
@jywarren @harshkhandeparkar yes actually I improved some spacings and
basically have done some linting then.
Rest it's all fine.
…On Thu 18 Apr, 2019, 5:57 PM Harsh Khandeparkar, ***@***.***> wrote:
***@***.**** approved this pull request.
Did you beautify the file or something?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1018 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHOHJL7EFGGF7IJX2EXB753PRBSLJANCNFSM4HGIQEJA>
.
|
@jywarren Actually those are some linting changes, not the code ones. |
Awesome, thanks all!!! |
Fixes #978
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!