-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image to pencil sketch module. #993
Comments
Is this an edge detect meta module? |
You can invert edge detect to do this |
But it will take vwry long to process |
And the image doesn't look quite like a sketch |
It needs some shading |
I did the same thing inverted edge detect. |
I made the hysteresis false so it doesn't take much time. |
👍
…On Sat 6 Apr, 2019, 1:30 PM Harshith pabbati, ***@***.***> wrote:
I made the hysteresis false so it doesn't take much time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#993 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhKOn0MAFkqD8gAjX_dRAZfPWADFsoePks5veFQngaJpZM4cgDGC>
.
|
But still it needs some effect to look like a sketch. |
Can this be achieved through a simple filter? Or maybe separabale filters + post processing? @tech4GT do you know anything this? |
Anything about this* |
I created this by mistake Does it look like a pencil sketch? @gauravano @harshithpabbati @publiclab/is-reviewers @jywarren |
Anyone would be surprised to know that it only contains pure black or pure white pixels, no intermediate |
@harshkhandeparkar lets make a trail invert it :) |
May be invert module makes it to look more like a sketch module. |
It is actually edge detect |
Yeah I know. |
I created it by mistake when I was finding opportunities for GPU accelerating edge-detect. |
May be you can open a pr this will improve the edge detect module. |
How will this improve edgeDetect? |
It's edge detect module right? |
Didn't you change anything in it? |
I did remove gaussian blur from it |
@harshithpabbati I tried to reproduce the same img but I am not able to. I forgot what I had done yesterday 😅. Sorry. |
Ok new plan:
|
Does this looks like a image sketch? I followed this article. |
I think it looks a bit more like pastel colors or watercolors. Maybe it needs to have some lines or gaps in between. We need to convolve some kind of filter. |
I think we'll have to do some google research. |
I was able to reproduce sketching in python. It may be possible for me to convert this into js. Can I proceed to this in javascript if you guys find the above results suitable. |
Hi @ataata107 , I was also working on it and made this below image by
If this looks good enough we can create this as a meta module. |
Also I found this project https://github.com/geraintluff/canvas-sketch if you could make something like this it looks really cool, It would be really great @ataata107 |
On it |
https://github.com/geraintluff/canvas-sketch |
A module which converts image into pencil sketch.
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: