Unordered list of modules #992
Comments
|
I'll take this one if that's ok! |
|
That'd be great, thanks!!!
…On Fri, Apr 5, 2019, 6:58 PM Terrence ***@***.***> wrote:
I'll take this one if that's ok!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#992 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJynsOhq_Kx0M9TJp84KeeAYMFgTZks5vd9UFgaJpZM4cfqIW>
.
|
|
Perfect! I'll get started tomorrow morning. Thanks! |
|
@jywarren Hey! Making sure I am on the right page. You wanted the "More Modules" option removed from the drop down correct? So the drop down defaults to the first option "Add QR"
|
|
👍 great work! |
|
@harshkhandeparkar Thanks! I'm hoping this is what you all were looking for! |
|
Yes we were kind of. One last thing, can you add a placeholder text to it?
…On Sat 6 Apr, 2019, 7:19 PM Terrence, ***@***.***> wrote:
@harshkhandeparkar <https://github.com/HarshKhandeparkar> *Thanks!* I'm
hoping this is what you all were looking for!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#992 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhKOn_Sq6PndSTn7cXS5x56-awtMvVQ8ks5veKXggaJpZM4cfqIW>
.
|
|
@harshkhandeparkar Sure! Something like this?
|
|
Perfect. Can you change the placeholder text as well? |
|
@harshithpabbati Absolutely! What would you like it to say? |
|
Something like "Select A Module" or "Select Modules" or "More Modules...". Whichever you think would best fit. You can add something of your own too. Awesome work!! |
|
Change the place holder name to more modules .... |
|
@harshkhandeparkar Thank you! I changed it to "Select A Module" as that seems to best fit what the user is doing. But I can of course make it whatever.
|
|
Great! Are you going to open PR (pull request) now? Thanks.
…On Sat 6 Apr, 2019, 7:35 PM Terrence, ***@***.***> wrote:
@harshkhandeparkar <https://github.com/HarshKhandeparkar> Thank you!
I changed it to "Select A Module" as that seems to best fit what the user
is doing. But I can of course make it whatever.
[image: placeholderUpdate]
<https://user-images.githubusercontent.com/47988669/55670509-41bdd300-5853-11e9-9795-3b87be3386db.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#992 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AhKOn8gtrdd8vpNPxd75FIY4UcBjbG02ks5veKmOgaJpZM4cfqIW>
.
|
|
Yep! I can do that now. Thanks! |
|
You can open a pr and mention me. |
|
@harshkhandeparkar PR Submitted |
|
@teisenhower make the capital A to small a. |
|
@harshithpabbati Sure no problem @harshkhandeparkar Should I make this change and then submit another PR? Thanks! |
|
Update this pr. |
|
You can commit to the same branch. |
|
new commit pushed. Now a lowercase 'a' Thanks! |
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
To Do: There is an open pr #710 which adds a helper method called
scopeQueryto image-sequencer demo code. You have to document it in the CONTRIBUTING.md file.📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file CONTRIBUTING.md in the
image-sequencerrepository (press the little pen Icon) and edit the line as shown below.Have a look here:
The "More Modules" option has to be removed and rather can be a made a value for select.
The files to be looked into are:
https://github.com/publiclab/image-sequencer/blob/main/examples/demo.js
https://github.com/publiclab/image-sequencer/blob/main/examples/lib/intermediateHtmlStepUi.js
And something to help out is :
https://stackoverflow.com/questions/21962124/how-to-set-a-value-for-a-selectize-js-input
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
The text was updated successfully, but these errors were encountered: