Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a function signature for blend step #382

Closed
Ankit-Singla opened this issue Oct 5, 2018 · 6 comments
Closed

Provide a function signature for blend step #382

Ankit-Singla opened this issue Oct 5, 2018 · 6 comments

Comments

@Ankit-Singla
Copy link

I have noticed that some actions, like blend require a function as input. I think it would be great to provide a function signature for the same, to make it more descriptive.
fnsignature

@gitmate
Copy link

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #344 (Add a function to create a gif from the outputs of all steps), #242 (Step API - various utility functions for modules and UIs to reference step state), #262 (Add Tests for getStep function), and #348 (Improve Images step Ui).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #344 (Add a function to create a gif from the outputs of all steps), #242 (Step API - various utility functions for modules and UIs to reference step state), #262 (Add Tests for getStep function), and #348 (Improve Images step Ui).

@ghost
Copy link

ghost commented Oct 5, 2018

@Ankit-Singla i want to work on this.Can you explain in a little more detail?

@Ankit-Singla
Copy link
Author

Sorry @varun560 , I don't have the authority to assign the issue to you. Actually this issue has not been confirmed yet. Let's just wait for the mentors to review this.

@tech4GT
Copy link
Member

tech4GT commented Oct 5, 2018

@Ankit-Singla Nice suggestion!! I think this is a great idea!!(I feel silly we didn't think of this haha)!
I think we can user the default value defined in info.json here! In fact this will be nice if use it for all modules! You can go ahead and work on this!
@varun560 I think @Ankit-Singla would be working on this issue, we can really use your help on other issues, Thanks to both of you!!

@Ankit-Singla
Copy link
Author

Thank you @tech4GT . I'll give it a try.

jywarren pushed a commit that referenced this issue Oct 10, 2018
* added gif feature

* increased frame duration n changed gif btn name

* removed inline css

* improved ui

* #363 Add placeholder option to input (#370)

* Add placeholder option to input , change type of brightness input to number

 Changes to be committed:
	modified:   examples/lib/defaultHtmlStepUi.js
	modified:   src/modules/Brightness/info.json

* change 0% to 0 in brightness placeholder

* Add gamma module (#374)

* Add gamma module

* update description

* Add matrix math module (#358)

* Add matrix math module

* add info.json file

* correct format of module

* Add a constant factor input field

* clone the pixels array

* change default values

* add extra information on convolution module (#381)

* adds default values to input fields for all module steps ( fixes #382 ) (#384)

* added default values to input fields for all module steps

* merged

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* Accept type images in input field #364 (#366)

* gif button name changed

* fixes #383 (#396)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix (#387)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* updated

* Issue #392 Fixes alignment of message in Add step box (#393)

*  Fixes alignment of message in Add step box

* fixes css info id

* updates class selector in demo

* Spacing changes

* correctly regulates the behaviour of all links (#397)

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* enables Save button for an action if any of its input fields gain focus (#394)

* Updated index.html (#379)

* add histogram module (#354)

* add histogram module

Signed-off-by: tech4GT <varun.gupta1798@gmail.com>

* add option to drop gradient

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix bug

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants