Module names are incorrectly used in HTML step selector in demo

[tech4GT]

The module names while adding them in the demo are wrong, they appear with spaces like "webgl-distort" appears as "webgl distort"
This is causing a critical failure of the demo. (in the main branch -- @jywarren)

=====@harshkhandeparkar=====

Update: this has been fixed by replacing the spaces with hyphens for now but a better, thorough fix would be better

Possible solution:

1. Modules have a name and an id to reference it. The id has hyphens(and only small letters) and the name has spaces and capitals. E.g.: webgl-distort(id), WebGL Distort (name)

2. We could assign hidden attributes or jQuery $.data properties to the module selector fields so that we can display the name but use the id for referencing the module name in the sequencer when a step is to be added.

=====@harshkhandeparkar=====

(Update (@jywarren) this was quick-fixed in #1073 but follow-ups included at the bottom of this issue)

Sent from my OnePlus3 using FastHub

Sent from my OnePlus3 using FastHub

[harshkhandeparkar]

@tech4GT I was trying to edit the issue body and remove the hyphen and add the space in the module body. I did this from this phone app and unfortunately it adds the footer text.

Sent from my OnePlus3 using FastHub

[jywarren]

Hi, I wasn't able to reproduce this, I found this to work correctly:

https://sequencer.publiclab.org/examples/#steps=webgl-distort{}

Can you clarify? Thanks!

[tech4GT]

@jywarren I think we already have a pr for this. #1073

[harshkhandeparkar]

urlHash works but the selector doesn't

[jywarren]

A gif of the issue would be great. And eventually a UI test!

[jywarren]

No, I used the selector in the page to get this url, and it worked there too.

[harshkhandeparkar]

Uh, it didn't work for me before, and even Nirav told me that it didn't work. Was a PR merged? Are you on the latest branch?

…

On Sat 25 May, 2019, 8:39 PM Jeffrey Warren, ***@***.***> wrote: No, I used the selector in the page to get this url, and it worked there too. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1061?email_source=notifications&email_token=AIJI5HZK3UCEI6NBUDONMRLPXFJCTA5CNFSM4HLTLZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWHTRIY#issuecomment-495925411>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H3WZPRF6LAW4W5IV2DPXFJCTANCNFSM4HLTLZHA> .

[jywarren]

Hi @harshkhandeparkar i know you said you're copying in all the relevant documentation for this bug, but in the meantime I am following the exact steps laid out in the chatroom and was able to reproduce this on the main branch in the demo, running locally:

[jywarren]

Exact issue for reproducing:

There is an issue with the step selection UI on the latest main branch, but not in the gh-pages demo, with modules that include spaces in their names?

To reproduce, the demo can be run locally from the latest main branch, using the "webgl-distort" module

The PR at #1073 substitutes hyphens for spaces (as a quick fix), and @harshkhandeparkar will be copying in suggestions for a more thorough fix here in a moment.

[jywarren]

I'd also like to recommend a test for this behavior so we can be sure it doesn't happen in the future! Thanks!

[jywarren]

Also, published v3.3.3!

[harshkhandeparkar]

@jywarren suggestions copied in the issue body itself.

[jywarren]

Closing, but opening a new issue for the tests!