-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of contributors fetched and stored to localStorage #61
Conversation
@jywarren Here is the working GIF |
How does this one relate to #54 ? Thanks!! |
Both solve one purpose i.e., fetch contributors and store them to localStorage to prevent network calls, but this one is for contributors that show up on |
Super. I've merged this. I am a little worried that the code is starting to become difficult to read for newcomers -- do you think some additional comments, or naming functions with names like Thanks!!! Also watch out that I'm renaming the |
@jywarren I completely agree, code readability is also important...I will do whatever is necessary to make the code more readable. I'll create a PR for it...
I hope everyone knows this... |
It's ok - any new clones will go from main and any PRs that go to master we
can redirect. Thanks!!!
…On Wed, Oct 10, 2018, 7:53 PM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I completely agree, code
readability is also important...I will do whatever is necessary to make the
code more readable. I'll create a PR for it...
Also watch out that I'm renaming the master branch to main in a moment
I hope everyone knows this...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6Y4e29kg3agf3Ml9L1uWGN1GT2Pks5ujd-KgaJpZM4XL8So>
.
|
Ah, that's great! |
Fixes #53