Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of contributors fetched and stored to localStorage #61

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

Rishabh570
Copy link
Collaborator

Fixes #53

@Rishabh570
Copy link
Collaborator Author

Rishabh570 commented Oct 7, 2018

@jywarren Here is the working GIF

another

@jywarren
Copy link
Member

jywarren commented Oct 8, 2018

How does this one relate to #54 ?

Thanks!!

@Rishabh570
Copy link
Collaborator Author

@jywarren #54 is for https://code.publiclab.org#r=all and this is for https://code.publiclab.org/ :)

@Rishabh570
Copy link
Collaborator Author

Both solve one purpose i.e., fetch contributors and store them to localStorage to prevent network calls, but this one is for contributors that show up on https://code.publiclab.org page 😄

@jywarren
Copy link
Member

Super. I've merged this. I am a little worried that the code is starting to become difficult to read for newcomers -- do you think some additional comments, or naming functions with names like function doThingWithEach() instead of anonymous function() could help? Or potentially even breaking it up into separate descriptively named files?

Thanks!!! Also watch out that I'm renaming the master branch to main in a moment. All future PRs should be against main. Thank you!!!

@Rishabh570
Copy link
Collaborator Author

@jywarren I completely agree, code readability is also important...I will do whatever is necessary to make the code more readable. I'll create a PR for it...

Also watch out that I'm renaming the master branch to main in a moment

I hope everyone knows this...

@jywarren
Copy link
Member

jywarren commented Oct 10, 2018 via email

@Rishabh570
Copy link
Collaborator Author

Ah, that's great!

@Rishabh570
Copy link
Collaborator Author

@jywarren I've done some refactoring work, the corresponding PR is #63
Please take a look, let me know if anything is needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants