Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes odd looking css: in image module everything should be in one row #629

Merged
merged 9 commits into from
Oct 13, 2020
Merged

Fixes odd looking css: in image module everything should be in one row #629

merged 9 commits into from
Oct 13, 2020

Conversation

Sagarpreet
Copy link
Contributor

Before:

Screenshot 2020-10-07 at 1 44 58 PM

After:

Screenshot 2020-10-07 at 2 04 06 PM

@welcome
Copy link

welcome bot commented Oct 7, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 7, 2020 •
edited
Loading

@Sagarpreet Sagarpreet mentioned this pull request Oct 7, 2020
Closed
14 tasks
jywarren
jywarren reviewed Oct 7, 2020
View reviewed changes
dist/PublicLab.Editor.js Outdated
@@ -370,7 +369,7 @@ function create (options) {
bureaucrat.emit('valid', validFiles);
var form = new FormData();
Object.keys(o.formData).forEach(function copyFormData(key) {
form[key] = o.formData[key];
form.append(key, o.formData[key]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, was this change from recent uncompiled changes or is it accidentally in dist? Thanks!

.gitignore
@@ -40,3 +40,6 @@ todo.txt

# Test output file
_SpecRunner.html

.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

dist/PublicLab.Editor.css
@@ -150,6 +150,7 @@
.ple-module {
padding: 20px;
border-top: 1px solid #ddd;
display: flex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@daemon1024 daemon1024 mentioned this pull request Oct 7, 2020
Merged
5 tasks
@Sagarpreet
Copy link
Contributor Author 

  ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/button_spec.js (line 7) (1)
     Expected false to be true. (2)
 Editor
   - exists, and has a textarea...X exists, and has a textarea
     ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 7) (1)
     Expected undefined not to be undefined. (2)
     TypeError: undefined is not an object (evaluating 'editor.options') in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 16) (3)
   - counts valid modules and enables publish button...X counts valid modules and enables publish button
     ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 7) (1)
     TypeError: undefined is not an object (evaluating 'editor.titleModule') in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 22) (2)
   - sends AJAX request on editor.publish()...X sends AJAX request on editor.publish()
     ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 7) (1)
     TypeError: undefined is not an object (evaluating 'editor.options') in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/editor_spec.js (line 41) (2)
 Errors
   - displays given errors...X displays given errors
     ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/errors_spec.js (line 7) (1)
   - does not display error alert if there are no errors...X does not display error alert if there are no errors
     ReferenceError: Can't find variable: PL in file:///home/travis/build/publiclab/PublicLab.Editor/spec/javascripts/errors_spec.js (line 25) (1)
 Formatter

@Sagarpreet Sagarpreet closed this Oct 13, 2020
@Sagarpreet Sagarpreet reopened this Oct 13, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2020

@jywarren
Copy link
Member

This looks like a syntax error somewhere, causing the whole PL object to not get defined properly. Could it be, somehow? Or might it have failed to fetch a dependency and then caused that error in compilation?

@sagarpreet-chadha
Copy link
Contributor

It has to be unrelated to this PR as it has only minor CSS change. What do you think?

@jywarren
Copy link
Member

Very strange. Maybe try rebasing it?

@Sagarpreet
Copy link
Contributor Author

@jywarren after rebasing, tests pass 🎉

@jywarren jywarren merged commit 2741425 into publiclab:main Oct 13, 2020
@jywarren
Copy link
Member

Super!!!

@Sagarpreet Sagarpreet deleted the 1.2 branch November 16, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sagarpreet @jywarren @sagarpreet-chadha