Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to clarify access to editor through index.html #243

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Updated README.md to clarify access to editor through index.html #243

merged 2 commits into from
Jan 16, 2020

Conversation

IgorWilbert
Copy link
Member

Fixes #240

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@rexagod
Copy link
Member

rexagod commented Jan 20, 2019

Hey! Could we explicitly mention something like CORS offline issue and provide a link to this the referenced issue as a solution in the Readme? What do you think?

@IgorWilbert
Copy link
Member Author

@rexagod sounds like a good idea, thank you! I updated README.md accordingly.

@rexagod rexagod requested a review from grvsachdeva January 21, 2019 12:25
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren jywarren merged commit 409c4d0 into publiclab:master Jan 16, 2020
@jywarren
Copy link
Member

Very nice, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon images in toolbar appear broken
4 participants