PL.Editor #162 Filter empty bold tags and instruct

[rexagod]

Fixes #162

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[rexagod]

@publiclab/reviewers

[jywarren]

Oh wow. Would a test of this be possible, do you think? Like, inserting some blank bold tags in a test and confirming that they (but not used bold tags like **this phrase**) are removed? Thank you so much!!!

If you're interested, a test could make for a good first-timers-only issue, to build a community here as @gauravano has suggested!

[rexagod]

Hey that's a great idea! I'll draft one up.

[jywarren]

Awesome. Shall i merge this now then?

[rexagod]

Should I add the timestamps fix to this one too first? Or is it okay?

[jywarren]

Yes, we'd best, thanks!

…

On Wed, Jan 2, 2019 at 4:20 PM Pranshu Srivastava ***@***.***> wrote: Should I add the timestamps fix to this one too first? Or is it okay? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#198 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ0lxfPVs7NtcnMlAcMq1mAIuMB0uks5u_SJ2gaJpZM4ZmVgx> .

[jywarren]

Awesome. Link to this from the first-timers issue and we'll have the test reference this PR, which could help future debugging! Thanks!!!

[rexagod]

@jywarren @gauravano @SidharthBansal Is #202 eligible for a fto? Please suggest any changes that I should implement in order to make it one. Thanks!