Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for scaling issues #340

Merged
merged 6 commits into from
Jul 11, 2019
Merged

fix for scaling issues #340

merged 6 commits into from
Jul 11, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Jul 10, 2019 •
edited
Loading

Fixes #320 fixes #219 !

@jywarren jywarren requested a review from sashadev-sky July 10, 2019 22:31
@jywarren jywarren mentioned this pull request Jul 10, 2019
Closed
This was referenced Jul 10, 2019
Closed
Closed
Closed
@sashadev-sky
Copy link
Member

looking now!

sashadev-sky
sashadev-sky reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and I couldn't manage to get a deletion error after a few tries, so that is a good sign! We also want to add this for scale then too right?

Should we add some error handling as well?

@jywarren
Copy link
Member Author

Great. Let's merge this as it's a pretty bad bug and do a follow-up! Thanks! +1 for both.

@jywarren jywarren merged commit a1b5bab into publiclab:main Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashadev-sky sashadev-sky sashadev-sky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't scale things down, only up edgeMinWidth and edgeMinHeight properties
2 participants
@jywarren @sashadev-sky