Deletion bug fix #269
Deletion bug fix #269
Conversation
|
@rexagod fixed the bug you found when deleting image in multiple select mode then dragging throws error |
|
@jywarren for some reason the dist file in the main repo isn't updated to reflect the changes I merged recently from FTOs. But it updates it here, so there are a few extra updates in the dist file |
|
This is a small change and i didn't get any feedback on it for a week so i just merged it |
|
It's been busy, apologies! I'm hoping that now that SoC has started officially, @rexagod can offer a bit more reviewing -- but perhaps we should brainstorm who else can offer reviews too, since it's going to be a busy summer! Thank you for taking action 👍 |
|
@jywarren sorry that was not good practice to merge. I don't know anyone is capable of reviewing front end code really. The FTOs haven't been sticking really but perhaps thats because we haven't implemented any strong system for follow up like in plots2. (create a page here with incentives for following the workflow through on this repo and a reviewers team, add FTO badges etc.) This repo has a simple setup so low barriers to entry and could benefit a lot from community coordination like @gauravano has been doing. I can do some extra work to try to make it gain traction. We can discuss further when we go over everything and other alternatives! |
|
That's ok and I hear you on wanting to shore up the contributor community
to get good feedback. Actually in image-sequencer there was an attempt to
use a service to auto generate an online demo for any PR, which could help
with front end reviews. I think it was called Surge.
…On Wed, May 29, 2019, 11:22 PM Sasha Boginsky ***@***.***> wrote:
@jywarren <https://github.com/jywarren> sorry that was not good practice
to merge. I don't know anyone is capable of reviewing front end code
really. The FTOs haven't been sticking really but perhaps thats because we
haven't implemented any strong system for follow up like in plots2. (create
a page here with incentives for following the workflow through on this repo
and a reviewers team, add FTO badges etc.) This repo has a simple setup so
low barriers to entry and could benefit a lot from community coordination
like @gauravano <https://github.com/gauravano> has been doing. I can do
some extra work to try to make it gain traction. We can discuss further
when we go over everything and other alternatives!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#269?email_source=notifications&email_token=AAAF6J4DRHB4Z4KF4SL22WLPX5B5BA5CNFSM4HOGLXM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRHUKI#issuecomment-497187369>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZJFJYBIMQM3WX45ZLPX5B5BANCNFSM4HOGLXMQ>
.
|
|
I found this - https://medium.com/onfido-tech/travis-surge-github-auto-deploy-every-pr-branch-and-tag-a6c8c790831f 😄. It would be exciting to try. Also, can feel you @sashadev-sky that it can be frustrating too sometimes to wait for approval on small things. But, you are really doing great work 🙌 and we'll surely get more hands once we get these projects to more stability. I think, our next goal towards coordination should be to use automation/tools at their best and also to develop a strategy which attracts more contributors and preparing more people to step-up as reviewers/maintainers. |
|
I think I'm going to ask SoC folks also to start to build on their initial work to begin thinking about and incorporating community building and reviewing as part of their summer projects. We are still figuring out how to not work in separate siloes. Thanks Gaurav I totally agree! 💓🔥🙌🏽 |
|
@jywarren @gauravano that sounds really cool will definitely check out surge! Yeah that's tough to figure out - you don't want people submitting approval reviews just for the sake of it. But the Mapknitter Rails upgrade project has been an awesome example of collaboration. I guess the trick is having simultaneous related projects. Next after that is asking someone directly for help |
Fixes ##186 (comment) (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
gruntIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!