-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean copy of #97 full resolution download #100
Conversation
Error is: src/edit/DistortableImage.Edit.js
295 | if (window && window.hasOwnProperty('warpWebGl')) warpWebGl(
^ Expected '{' and instead saw 'warpWebGl'.
302 | }
^ Missing semicolon.
255 | var image = overlay._image;
^ 'image' is defined but never used.
295 | if (window && window.hasOwnProperty('warpWebGl')) warpWebGl(
^ 'warpWebGl' is not defined. |
Fixed this, I believe! |
Wow, we are /almost/ there! @rexagod this is a different build process and i'm less familiar with it (even though i'm an author of this lib! 😂 ) do you have an idea of how we can include the needed lib besides where i've done it here? Running "jshint:source" (jshint) task
src/edit/DistortableImage.Edit.js
298 | warpWebGl(
^ 'warpWebGl' is not defined. |
@sashadev-sky are you at all familiar with Karma tests or with |
@jywarren not familiar with them but I’ll take a look today anyway! |
…ortableImage into jywarren-fullres-dl
Complete!!! Amazing work folks, this is a big one! |
Blog post coming soon! |
Added to MapKnitter here: publiclab/mapknitter@a5de9bd |
* Fix jshint/karma errors and duplicate code from #100 * menu API abstractions * add a user-friendly demo example * Update index.html * window->L.DI and document _demonstrator()
* Fix jshint/karma errors and duplicate code from #100 * Add image order functionality * Add docs for image ordering * Add leaflet links to docs * jpg -> png * Remove older switching technique * Change mappings * wire _toggleOrder to toolbar icon
Noting that we're moving to the
main
branch, so this'll need to be merged with that.Based on #97 by @John905
This needs some way to pass in an
fullResolutionSrc
so that we can warp an original image and not the preview, for example on MapKnitter.Fixes #124 too!
Fixes #83