Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar disappears when clicking on rotate icon, then on image (in simple demo) #221

Closed
flopail opened this issue Apr 16, 2019 · 7 comments

Comments

@flopail
Copy link

flopail commented Apr 16, 2019

... and no way to increase/reduce proportionally image size. Does something change recently in simple demo (below) ? https://publiclab.github.io/Leaflet.DistortableImage/examples/

Thanks,
:)

@welcome
Copy link

welcome bot commented Apr 16, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@rexagod
Copy link
Member

rexagod commented Apr 16, 2019

@flopail This has been fixed in #201. As for the proportional resize, we have a "scale" function for the same, and we are working on including it in the toolbar. Thanks!

@sashadev-sky
Copy link
Member

@flopail ^ to add on I think you can access it now with the hotkey s but in the PR referenced above we are also fixing a bug where hitting s again won't toggle you out of scale mode so you'll have to hit a hotkey for another handle if you want to get out of it .. until we merge mentioned PR

@sashadev-sky sashadev-sky mentioned this issue Apr 17, 2019
7 tasks
@flopail
Copy link
Author

flopail commented Apr 17, 2019

Thank you @rexagod and @sashadev-sky !

@sashadev-sky
Copy link
Member

ok this is fixed now via #201 ... @jywarren do we need to do anything else to make sure the demo itself is updated?

@jywarren
Copy link
Member

jywarren commented Apr 20, 2019 via email

@sashadev-sky
Copy link
Member

@jywarren awesome! Updates are live there.

@flopail please revisit demo now and your issue should be resolved!

Thank you, closing via #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants