Fixes optional price behavior #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Oct 28, 2018
| @@ -55,20 +55,18 @@ const createParseJourney = (profile, opt, data) => { | |||
| // targetCtx: 'D', | |||
| // buttonText: 'To offer selection' | |||
| // } ] | |||
| res.price = {amount: null, hint: 'No pricing information available.'} | |||
There was a problem hiding this comment.
Please assign null as the default value.
|
Technically someone could rely one the behaviour that, if |
Right this is a breaking change... |
derhuerst
added a commit
that referenced
this pull request
Mar 11, 2019
derhuerst
added a commit
that referenced
this pull request
Mar 12, 2019
derhuerst
added a commit
that referenced
this pull request
Mar 21, 2019
derhuerst
added a commit
that referenced
this pull request
May 20, 2019
derhuerst
added a commit
that referenced
this pull request
Aug 16, 2019
|
Sorry, I just noticed that I have added this behaviour in 8677a1c on branch |
derhuerst
added a commit
that referenced
this pull request
Sep 10, 2019
derhuerst
added a commit
that referenced
this pull request
Dec 26, 2019
derhuerst
added a commit
that referenced
this pull request
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in fptf amount and currency should be required. If amount is not available the whole price object is nil