Skip to content

Commit

Permalink
DB E2E/integration tests: disable .realtimeDataUpdatedAt validation ✅
Browse files Browse the repository at this point in the history
remotely related: #331
  • Loading branch information
derhuerst committed Dec 17, 2024
1 parent 8432ff1 commit 29f922b
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 11 deletions.
2 changes: 2 additions & 0 deletions test/e2e/db.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const cfg = {
minLongitude: 6.896517,
maxLongitude: 16.180237,
validateJourneyTickets: false, // don't validate a journey's tickets
// with `journeys()` & `refreshJourney()`, don't validate .realtimeDataUpdatedAt
validateJourneysRealtimeDataUpdatedAt: false,
};

const validate = createValidate(cfg);
Expand Down
30 changes: 19 additions & 11 deletions test/e2e/lib/validators.js
Original file line number Diff line number Diff line change
Expand Up @@ -440,23 +440,31 @@ const validateJourneys = (val, js, name = 'journeys') => {
};
const createValidateJourneys = () => validateJourneys;

const validateJourneysResult = (val, res, name = 'journeysResult') => {
a.ok(isObj(res), name + ' must be an object');
// todo: `earlierRef`, `laterRef`
val.journeys(val, res.journeys, name + '.journeys');
const createValidateJourneysResult = (cfg) => {
const validateJourneysResult = (val, res, name = 'journeysResult') => {
a.ok(isObj(res), name + ' must be an object');
// todo: `earlierRef`, `laterRef`
val.journeys(val, res.journeys, name + '.journeys');

val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
if (cfg.validateJourneysRealtimeDataUpdatedAt !== false) {
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
}
};
return validateJourneysResult;
};
const createValidateJourneysResult = () => validateJourneysResult;

const validateRefreshJourneyResult = (val, res, name = 'refreshJourneyResult') => {
a.ok(isObj(res), name + ' must be an object');
const createValidateRefreshJourneyResult = (cfg) => {
const validateRefreshJourneyResult = (val, res, name = 'refreshJourneyResult') => {
a.ok(isObj(res), name + ' must be an object');

val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
if (cfg.validateJourneysRealtimeDataUpdatedAt !== false) {
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
}

val.journey(val, res.journey, name + '.journey');
val.journey(val, res.journey, name + '.journey');
};
return validateRefreshJourneyResult;
};
const createValidateRefreshJourneyResult = () => validateRefreshJourneyResult;

const validateTrip = (val, trip, name = 'trip') => {
const withFakeTripId = Object.assign({
Expand Down

0 comments on commit 29f922b

Please sign in to comment.