-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cw721-base minter updatable via two-step ownership transfer. #109
Merged
Commits on Feb 4, 2023
-
Make cw721-base minter updatable via three-step ownership transfer.
This makes a breaking change to cw721-base in that it makes the `minter` field on `cw721_base::MinterResponse` optional. Before: ```rust pub struct MinterResponse { pub minter: String, } ``` After: ```rust pub struct MinterResponse { pub minter: Option<String>, } ``` It also makes a breaking change to the `ContractError` enum in that it removes the `Unauthorized` variant in favor of cw-ownable's more descriptive `OwnershipError`. It then extends the `cw721_base`, but not the `cw721` standard's, `ExecuteMsg` with [`cw-ownable`](https://crates.io/crates/cw-ownable)'s `UpdateOwnership` enum variant, and extends the `QueryMsg` with `cw-ownable`'s `Ownership {}` query. Using these messages, the current minter on the contract may nominate a new minter, who may accept or reject this nomination.
Configuration menu - View commit details
-
Copy full SHA for 3a5f6f8 - Browse repository at this point
Copy the full SHA 3a5f6f8View commit details
Commits on Feb 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7a0c0c3 - Browse repository at this point
Copy the full SHA 7a0c0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf7418 - Browse repository at this point
Copy the full SHA 4bf7418View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29ec052 - Browse repository at this point
Copy the full SHA 29ec052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6857d8b - Browse repository at this point
Copy the full SHA 6857d8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e0c3e - Browse repository at this point
Copy the full SHA 21e0c3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 153fe5c - Browse repository at this point
Copy the full SHA 153fe5cView commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ec5e60b - Browse repository at this point
Copy the full SHA ec5e60bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87e7d89 - Browse repository at this point
Copy the full SHA 87e7d89View commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6b934b6 - Browse repository at this point
Copy the full SHA 6b934b6View commit details
Commits on Feb 9, 2023
-
Update contracts/cw721-base/src/upgrades/v0_16.rs
Co-authored-by: Larry Engineer <26318510+larry0x@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a4558d8 - Browse repository at this point
Copy the full SHA a4558d8View commit details
Commits on Feb 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a7e4210 - Browse repository at this point
Copy the full SHA a7e4210View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.