Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for issue 6141 #6221

Closed
wants to merge 1 commit into from
Closed

Conversation

sir-script
Copy link

@sir-script sir-script commented Jul 17, 2024

PR Test Case for #6141
In my opinion, both clients should receive same data (also client who made the modification, cause server may also update timestamp entries)

@pubkey
Copy link
Owner

pubkey commented Aug 1, 2024

Hi @sir-script
I am sorry for the late response.
I run your test locally and I think your test is not correct.
You can use the method await ensureCollectionsHaveEqualState(c1, c2); to ensure the equalness of both sides.
In all steps of your test, after await awaitInSync(); both sides are in sync and it behaves correctly.

You last comparison of the test only compares the emitted events which are not equal. This looks correct because the received$ observable only emits actual received data and the side that does the change will not receive its own data changes.
So state1Data only contains the events of data that was modified on collection2. So it only has one event where Doe3 was set. This seems to be the correct behavior.

@sir-script
Copy link
Author

sir-script commented Aug 1, 2024

Hi @pubkey, thanks for reviewing it.

I would like to book a Quick Consulting Session to get more detailed info about this behaviour and other related concepts from rxdb.
Is it guaranteed that we will have this session with you if I book it online?

Cheers,
Michael

@pubkey
Copy link
Owner

pubkey commented Aug 1, 2024

@sir-script Yes these sessions are with me in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants