Feature: Ability to use a responseModifier for GraphQL push replication #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pubkey
reviewed
Feb 2, 2023
docs-src/replication-graphql.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ```js |
There was a problem hiding this comment.
This should be 'ts' instead of 'js' because your code below contains typings.
There was a problem hiding this comment.
Yes! I also changed it for the example of the pull.responseModifier now.
pubkey
reviewed
Feb 2, 2023
docs-src/replication-graphql.md
Outdated
| /** | ||
| * In this example we aggregate the conflicting documents from a response object | ||
| */ | ||
| const pullResponse = plainResponse; |
There was a problem hiding this comment.
Shouldnt this variable be called 'pushResponse' ?
There was a problem hiding this comment.
Oops… it's unused anyway, so I removed it.
- Changed from 'js' to 'ts' in code blocks that explain "pull.responseModifier" and "push.responseModifier" - Removed unused variable definition with wrong name
|
Great work. Merged. |
|
Thanks 🙏 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Todos