-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional React Native example #3488
Conversation
examples/react-native/package.json
Outdated
@@ -24,14 +24,15 @@ | |||
}, | |||
"main": "node_modules/expo/AppEntry.js", | |||
"dependencies": { | |||
"expo": "37.0.12", | |||
"expo": "^43.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pin the version. We do not use package-lock for several reasons. So remove the ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. Still in draft while I sort out some jest/react-native issues
examples/react-native/package.json
Outdated
"rxdb": "file:rxdb-local.tgz", | ||
"rxjs": "7.3.1" | ||
"rxdb-hooks": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also pin the version here and at the line below.
@pubkey Do you have any reccomendations on the failing tests?
Not a testing expert. |
Ignore I am not sure about the checksum missmatch. |
@alex-hladun do we really have to add |
No, our team just uses it as part of our architecture. I'll take it out. |
@pubkey Implemented native context and removed rxdb-hooks. Added delete hero function. |
Can this be merged? @alex-hladun |
Yep, everything is good on my end.
…________________________________
From: Daniel Meyer ***@***.***>
Sent: Sunday, November 21, 2021 4:14:47 AM
To: pubkey/rxdb ***@***.***>
Cc: Alex Hladun ***@***.***>; Mention ***@***.***>
Subject: Re: [pubkey/rxdb] Functional React Native example (PR #3488)
Can this be merged? @alex-hladun<https://github.com/alex-hladun>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3488 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANZB2XO43WPXOXOADLLZK7LUNDICPANCNFSM5HQB24NA>.
|
This PR contains: Improved React native example implementation
Describe the problem you have without this PR