Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments: "digest" and "length" are not generated when using storage that is not based on pouch #3548

Closed
y-lazarenka opened this issue Dec 5, 2021 · 2 comments
Closed

Attachments: "digest" and "length" are not generated when using storage that is not based on pouch #3548

y-lazarenka opened this issue Dec 5, 2021 · 2 comments

Comments

@y-lazarenka
Copy link

We implemented our own idb storage. We expected "digest" and "length" to be generated when attachment is created, but unfortunately these properties are undefined.

Screenshot_28
Screenshot_27
@pubkey
Copy link
Owner

pubkey commented Dec 11, 2021

Hi @nothingkid
So the reason is that in the past we only had pouchdb which creates the attachment digest by itself.
I think we should put that inside of RxDB instead so that the RxStorage implementation does not have to take care of it.
As I am preparing the next major release at the moment, you can create a PR if you want.
Otherwise I will put that into the backlog.

pubkey added a commit that referenced this issue Dec 13, 2021
@pubkey
CHANGE #3548 create attachments meta by RxDB not by the RxStorage
5d38ce4
@pubkey
Copy link
Owner

pubkey commented Dec 13, 2021

I added the feature in 5d38ce4

@pubkey pubkey closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pubkey @y-lazarenka